Patch to lisp/bs.el

Patch to lisp/bs.el

[CHENG Gao]

Reading Coding Conventions, I found it's not desirable to use
next-line/previous-line. Searching Emacs files generate some files that
dont follow this.

Below is patch to lisp/bs.el with next-line/previous replaced with
forward-line.

--- bs.el.orig	2004-11-19 23:55:04.000000000 +0800
+++ bs.el	2004-11-19 23:56:08.000000000 +0800
@@ -1006,7 +1006,7 @@
   "Move cursor vertically up one line.
 If on top of buffer list go to last line."
   (interactive "p")
-  (previous-line 1)
+  (forward-line -1)
   (if (<= (count-lines 1 (point)) (1- bs-header-lines-length))
       (progn
 	(goto-char (point-max))
@@ -1027,7 +1027,7 @@
   (let ((last (line-end-position)))
     (if (eq last (point-max))
 	(goto-line (1+ bs-header-lines-length))
-      (next-line 1))))
+      (forward-line 1))))
 
 (defun bs-visits-non-file (buffer)
   "Return t or nil whether BUFFER visits no file.

-- 
德不孤，必有邻
         -- 《论语-里仁》

Re: Patch to lisp/bs.el

[Andreas Schwab]

CHENG Gao <chenggao@gmail.com> writes:

> Reading Coding Conventions, I found it's not desirable to use
> next-line/previous-line. Searching Emacs files generate some files that
> dont follow this.
>
> Below is patch to lisp/bs.el with next-line/previous replaced with
> forward-line.

I don't this this is correct, and previous-line/next-line are intented
here.  Note that forward-line does _not_ move vertically in general, but
rather to the beginning of the addressed line.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Patch to lisp/bs.el

[CHENG Gao]

(*bash*)Thank you for your clarification. I am too much a ELISP newbie.

-- 
春风和气纯乎纯矣
烈日秋霜正者正也
            -- 河南嵩县二程祠道学堂联

Re: Patch to lisp/bs.el

[Thien-Thi Nguyen]

CHENG Gao <chenggao@gmail.com> writes:

   (*bash*)Thank you for your clarification.
   I am too much a ELISP newbie.

newbiehood is a precious time for the properly receptive newbie.
enjoy it and exploit it while you can.  better to be a newbie on
the make than to be a wizard on the fake...

but don't believe me, wander where and as you will.

thi

Re: Patch to lisp/bs.el

[Richard Stallman]

These particular functions are intended to move vertically up and down
(as the doc strings say), so using next-line and previous-line is correct.