From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: passing arg of `merge_face_heights' makes integer from pointer without a cast Date: Thu, 04 Nov 2004 15:43:29 -0500 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1099601153 30859 80.91.229.6 (4 Nov 2004 20:45:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 Nov 2004 20:45:53 +0000 (UTC) Cc: emacs-devel@gnu.org, miles@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 04 21:45:46 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CPoUM-0004ZG-00 for ; Thu, 04 Nov 2004 21:45:46 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CPocW-0004Le-Bx for ged-emacs-devel@m.gmane.org; Thu, 04 Nov 2004 15:54:12 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CPocA-0004Gq-7y for emacs-devel@gnu.org; Thu, 04 Nov 2004 15:53:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CPoc9-0004G9-0f for emacs-devel@gnu.org; Thu, 04 Nov 2004 15:53:49 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CPoc8-0004Ft-Oh for emacs-devel@gnu.org; Thu, 04 Nov 2004 15:53:48 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CPoTe-0005YB-Kd for emacs-devel@gnu.org; Thu, 04 Nov 2004 15:45:02 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CPoS9-000442-TR; Thu, 04 Nov 2004 15:43:29 -0500 Original-To: Andreas Schwab In-reply-to: (message from Andreas Schwab on Thu, 04 Nov 2004 01:23:23 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29440 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29440 passing arg of `merge_face_heights' makes integer from pointer without a cast Sender: emacs-devel-bounces+rms=gnu.org@gnu.org X-Spam-Status: No, hits=0.0 required=5.0 tests=RCVD_IN_ORBS,USER_AGENT_GNUS_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) I'm getting numerous warnings of the kind mentioned in the subject when compiling xface.c. I can't see how that can work at all given that GCPRO is passed a value that is actually not a Lisp_Object. It makes no sense to GCPRO something that really contains a struct named_merge_point *. In addition, this value isn't really used in merge_face_heights, so why pass it at all? That structure looks like something for which cons cells would work, so why not use cons cells?