unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org, miles@gnu.org
Subject: Re: passing arg of `merge_face_heights' makes integer from pointer without a cast
Date: Thu, 04 Nov 2004 15:43:29 -0500	[thread overview]
Message-ID: <E1CPoS9-000442-TR@fencepost.gnu.org> (raw)
In-Reply-To: <je654mbgxw.fsf@sykes.suse.de> (message from Andreas Schwab on Thu, 04 Nov 2004 01:23:23 +0100)

    passing arg of `merge_face_heights' makes integer from pointer
     without a cast
    Sender: emacs-devel-bounces+rms=gnu.org@gnu.org
    X-Spam-Status: No, hits=0.0 required=5.0
	    tests=RCVD_IN_ORBS,USER_AGENT_GNUS_UA
	    version=2.55
    X-Spam-Level: 
    X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)

    I'm getting numerous warnings of the kind mentioned in the subject when
    compiling xface.c.  I can't see how that can work at all given that GCPRO
    is passed a value that is actually not a Lisp_Object.

It makes no sense to GCPRO something that really contains a struct
named_merge_point *.  In addition, this value isn't really used
in merge_face_heights, so why pass it at all?

That structure looks like something for which cons cells would work,
so why not use cons cells?

  reply	other threads:[~2004-11-04 20:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-04  0:23 passing arg of `merge_face_heights' makes integer from pointer without a cast Andreas Schwab
2004-11-04 20:43 ` Richard Stallman [this message]
2004-11-04 21:16   ` Miles Bader
2004-11-05 15:01     ` Richard Stallman
2004-11-05 22:34       ` Miles Bader
2004-11-06 15:19         ` Richard Stallman
2004-11-08  3:41           ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1CPoS9-000442-TR@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).