compilation-mode makes the buffer read-only

compilation-mode makes the buffer read-only

[Stefan]

The recent change that makes compilation-mode buffers read-only breaks
C-u M-x checkdoc-current-buffer RET

Of course I can add some inhibit-read-only bindings in checkdoc.el but why
not avoid those incompatibilities altogether.  How about the patch below?


        Stefan


--- orig/lisp/progmodes/compile.el
+++ mod/lisp/progmodes/compile.el
@@ -939,7 +939,9 @@
 	      (unless (getenv "EMACS") '("EMACS=t"))
 	      (copy-sequence process-environment))))
 	(if (not (eq mode t))
-	    (funcall mode)
+	    (progn
+	      (funcall mode)
+	      (setq buffer-read-only t))
 	  (setq buffer-read-only nil)
 	  (with-no-warnings (comint-mode))
 	  (compilation-shell-minor-mode))
@@ -1203,8 +1205,6 @@
   "Prepare the buffer for the compilation parsing commands to work.
 Optional argument MINOR indicates this is called from
 `compilation-minor-mode'."
-  (unless minor
-    (setq buffer-read-only t))
   (make-local-variable 'compilation-current-error)
   (make-local-variable 'compilation-messages-start)
   (make-local-variable 'compilation-error-screen-columns)

Re: compilation-mode makes the buffer read-only

[Daniel Pfeiffer]

Saluton,

Stefan <monnier@iro.umontreal.ca> skribis:

> The recent change that makes compilation-mode buffers read-only breaks
> C-u M-x checkdoc-current-buffer RET
> 
> Of course I can add some inhibit-read-only bindings in checkdoc.el but why
> not avoid those incompatibilities altogether.  How about the patch below?

I did not do that change.  I don't know what it was good for and so I don't
know if your patch solves the same problem.

I was also annoyed by this change because it breaks what is documented in the
example file, namely that for the broken output of Oracle's Pro*C, you can
just delete the newline in the middle of the filename to get it reparsed and
consequently found.

coralament / best Grötens / liebe Grüße / best regards / elkorajn salutojn
Daniel Pfeiffer

-- 
lerne / learn / apprends / lär dig / ucz się    Esperanto:
                              http://lernu.net/

Re: compilation-mode makes the buffer read-only

[Richard Stallman]

Your change would turn on buffer-read-only for modes other than
compilation-mode.  That does not seem desirable.

What is your intent here?

Re: compilation-mode makes the buffer read-only

[Stefan]

> Your change would turn on buffer-read-only for modes other than
> compilation-mode.  That does not seem desirable.

Presumably these other modes all derive from compilation-mode
(i.e. things like grep-mode), so they already are put in read-only mode.
But I agree that I don't understand the code well enough to know for sure
the implications of my change, hence my question.

> What is your intent here?

As mentioned the change

	* progmodes/compile.el (compilation-start): Assume compilation-mode
	will make the buffer read-only.
	(compilation-mode): Take arg name-of-mode.
	(compilation-setup): Make buffer read-only.
	(compilation-handle-exit): Bind inhibit-read-only.

makes the buffer read-only in cases where it is not expected.  This was
already partly fixed by making the buffer read-only for the non-minor-mode
case only, and my change intended to further reduce the number of cases
where the buffer is made read-only by moving it to `compilation-start'.


        Stefan

Re: compilation-mode makes the buffer read-only

[Richard Stallman]

     my change intended to further reduce the number of cases
    where the buffer is made read-only by moving it to `compilation-start'.

Would you please be more specific?  Can you tell us one or more
specific cases where currently this makes the buffer read-only but you
think it should not?

Re: compilation-mode makes the buffer read-only

[Stefan Monnier]

>      my change intended to further reduce the number of cases
>     where the buffer is made read-only by moving it to `compilation-start'.

> Would you please be more specific?  Can you tell us one or more
> specific cases where currently this makes the buffer read-only but you
> think it should not?

Try C-u M-x checkdoc-current-buffer RET for one example (as mentioned in
the original message of this thread).


        Stefan

Re: compilation-mode makes the buffer read-only

[Richard Stallman]

    > Would you please be more specific?  Can you tell us one or more
    > specific cases where currently this makes the buffer read-only but you
    > think it should not?

    Try C-u M-x checkdoc-current-buffer RET for one example (as mentioned in
    the original message of this thread).

So how about changing checkdoc-current-buffer?

Re: compilation-mode makes the buffer read-only

[Stefan]

>> Would you please be more specific?  Can you tell us one or more
>> specific cases where currently this makes the buffer read-only but you
>> think it should not?

>     Try C-u M-x checkdoc-current-buffer RET for one example (as mentioned in
>     the original message of this thread).

> So how about changing checkdoc-current-buffer?

Because I suspect that checkdoc is but one example that indicates we're
breaking backward compatibility, so maybe it's better to restrict this new
behavior to new code.


        Stefan

Re: compilation-mode makes the buffer read-only

[Richard Stallman]

    Because I suspect that checkdoc is but one example that indicates we're
    breaking backward compatibility, so maybe it's better to restrict this new
    behavior to new code.

My goal was to change this more or less generally.
SInce it is easy to fix any specific case, people will adapt.