From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: how-many/count-matches for non-interactive use Date: Tue, 02 Nov 2004 03:53:52 -0500 Message-ID: References: <87pt3m5vqk.fsf@oak.pohoyda.family> <87zn2mh5jk.fsf-monnier+emacs@gnu.org> <87is99nznd.fsf-monnier+emacs@gnu.org> <200410172053.i9HKrdL01136@raven.dms.auburn.edu> <200410190158.i9J1wrH25523@raven.dms.auburn.edu> <200410200127.i9K1Rpp28384@raven.dms.auburn.edu> <200410210308.i9L38Dm10997@raven.dms.auburn.edu> <200410222222.i9MMMD515903@raven.dms.auburn.edu> <200410232036.i9NKaTc05040@raven.dms.auburn.edu> <200410260309.i9Q39p205228@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1099385937 5459 80.91.229.6 (2 Nov 2004 08:58:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 Nov 2004 08:58:57 +0000 (UTC) Cc: jpw@gnu.org, klm@zope.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca, storm@cua.dk, alexander.pohoyda@gmx.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 02 09:58:51 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1COuV8-0001wx-00 for ; Tue, 02 Nov 2004 09:58:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COudA-0002vi-9b for ged-emacs-devel@m.gmane.org; Tue, 02 Nov 2004 04:07:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1COuap-0002SN-3J for emacs-devel@gnu.org; Tue, 02 Nov 2004 04:04:43 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1COuam-0002RQ-Fv for emacs-devel@gnu.org; Tue, 02 Nov 2004 04:04:40 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COuam-0002Qy-4f for emacs-devel@gnu.org; Tue, 02 Nov 2004 04:04:40 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1COuRZ-0006lb-Lm for emacs-devel@gnu.org; Tue, 02 Nov 2004 03:55:09 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1COuQK-0001DG-R0; Tue, 02 Nov 2004 03:53:53 -0500 Original-To: Luc Teirlinck In-reply-to: <200410260309.i9Q39p205228@raven.dms.auburn.edu> (message from Luc Teirlinck on Mon, 25 Oct 2004 22:09:51 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29297 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29297 I've gone through most of the files in subdirectories. A few files I didn't handle but instead sent mail to their maintainers. I checked the rest, and found many incorrect calls to interactive-p. I fixed all of them except for the calls to help-setup-xref. (I checked in some of these files but did not have time for all.) I found that advice.el and another file that modify existing code couldn't be fixed by adding an argument. So I decided it was necessary to add a function called-interactively-p for them. I was able to check in the documentation for this, but not yet the code. I did not fix the calls to help-setup-xref, but I've concluded that they all need to be fixed. It is not right for this decision to be affected by whether a keyboard macro is running. I think the easiest fix is to change all of those cases to call called-interactively-p. Could someone offer to do that, after I check that function in?