From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Another bug with the macro counter
Date: Mon, 01 Nov 2004 02:24:02 -0500
Message-ID: <E1COWXq-0001f6-CV@fencepost.gnu.org>
References: <200410210107.i9L176B10842@raven.dms.auburn.edu>
	<200410300238.i9U2cOD02290@raven.dms.auburn.edu>
	<200410300327.i9U3RWW02355@raven.dms.auburn.edu>
	<m14qkcyhpj.fsf-monnier+emacs@gnu.org>
	<200410301451.i9UEpNG02900@raven.dms.auburn.edu>
	<m3zn23na1v.fsf@kfs-l.imdomain.dk>
Reply-To: rms@gnu.org
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1099294053 16224 80.91.229.6 (1 Nov 2004 07:27:33 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 1 Nov 2004 07:27:33 +0000 (UTC)
Cc: teirllm@dms.auburn.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 01 08:27:29 2004
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1COWbB-000171-00
	for <ged-emacs-devel@m.gmane.org>; Mon, 01 Nov 2004 08:27:29 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33)
	id 1COWjA-0005bp-DL
	for ged-emacs-devel@m.gmane.org; Mon, 01 Nov 2004 02:35:44 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1COWh5-00048A-CI
	for emacs-devel@gnu.org; Mon, 01 Nov 2004 02:33:35 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1COWh4-00046k-4t
	for emacs-devel@gnu.org; Mon, 01 Nov 2004 02:33:34 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1COWh4-00046d-1O
	for emacs-devel@gnu.org; Mon, 01 Nov 2004 02:33:34 -0500
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1COWZ2-0001vb-2w
	for emacs-devel@gnu.org; Mon, 01 Nov 2004 02:25:16 -0500
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1COWXq-0001f6-CV; Mon, 01 Nov 2004 02:24:02 -0500
Original-To: storm@cua.dk (Kim F. Storm)
In-reply-to: <m3zn23na1v.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:29258
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29258

    I think it will be better if kmacro.el defines a function

    (defun kmacro-quit ()
       (or appending-to-kbd-macro
	   (kmacro-ring-empty-p)
	   (kmacro-pop-ring))
       (setq appending-to-kbd-macro nil))

    which does the cleanup and then simply call this as

	  (if (fboundp 'kmacro-quit)
	    (kmacro-quit))

That is definitely cleaner.