From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: how-many/count-matches for non-interactive use Date: Sat, 23 Oct 2004 14:49:05 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <87pt3m5vqk.fsf@oak.pohoyda.family> <87zn2mh5jk.fsf-monnier+emacs@gnu.org> <87is99nznd.fsf-monnier+emacs@gnu.org> <200410172053.i9HKrdL01136@raven.dms.auburn.edu> <200410190158.i9J1wrH25523@raven.dms.auburn.edu> <200410200127.i9K1Rpp28384@raven.dms.auburn.edu> <200410210308.i9L38Dm10997@raven.dms.auburn.edu> <200410222222.i9MMMD515903@raven.dms.auburn.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1098557467 28228 80.91.229.6 (23 Oct 2004 18:51:07 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 23 Oct 2004 18:51:07 +0000 (UTC) Cc: jpw@gnu.org, klm@zope.com, emacs-devel@gnu.org, monnier@iro.umontreal.ca, storm@cua.dk, alexander.pohoyda@gmx.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 23 20:51:01 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CLQyj-0005XU-00 for ; Sat, 23 Oct 2004 20:51:01 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLR6I-0005De-29 for ged-emacs-devel@m.gmane.org; Sat, 23 Oct 2004 14:58:50 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CLR4k-00048D-Gg for emacs-devel@gnu.org; Sat, 23 Oct 2004 14:57:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CLR4j-00046M-59 for emacs-devel@gnu.org; Sat, 23 Oct 2004 14:57:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLR4i-00045n-N8 for emacs-devel@gnu.org; Sat, 23 Oct 2004 14:57:12 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CLQx4-0006Aa-Lk for emacs-devel@gnu.org; Sat, 23 Oct 2004 14:49:18 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CLQwr-0003wG-Kf; Sat, 23 Oct 2004 14:49:05 -0400 Original-To: Luc Teirlinck In-reply-to: <200410222222.i9MMMD515903@raven.dms.auburn.edu> (message from Luc Teirlinck on Fri, 22 Oct 2004 17:22:13 -0500 (CDT)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28798 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28798 The call to interactive-p in ibuf-ext.el is in ibuffer-kill-line. Since it conditions the choice of whether to use call-interactively, it is most surely wrong. I think this is the right fix; would someone who uses ibuf-ext.el please check it? *** ibuf-ext.el 23 Oct 2004 10:00:10 -0400 1.39 --- ibuf-ext.el 23 Oct 2004 13:45:58 -0400 *************** *** 645,660 **** (ibuffer-update nil t)) ;;;###autoload ! (defun ibuffer-kill-line (&optional arg) "Kill the filter group at point. See also `ibuffer-kill-filter-group'." ! (interactive "P") (ibuffer-aif (save-excursion (ibuffer-forward-line 0) (get-text-property (point) 'ibuffer-filter-group-name)) (progn (ibuffer-kill-filter-group it)) ! (funcall (if (interactive-p) #'call-interactively #'funcall) #'kill-line arg))) (defun ibuffer-insert-filter-group-before (newgroup group) --- 645,660 ---- (ibuffer-update nil t)) ;;;###autoload ! (defun ibuffer-kill-line (&optional arg interactive) "Kill the filter group at point. See also `ibuffer-kill-filter-group'." ! (interactive "P\np") (ibuffer-aif (save-excursion (ibuffer-forward-line 0) (get-text-property (point) 'ibuffer-filter-group-name)) (progn (ibuffer-kill-filter-group it)) ! (funcall (if interactive-p #'call-interactively #'funcall) #'kill-line arg))) (defun ibuffer-insert-filter-group-before (newgroup group)