From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: [vivek@zeus.com: url libraries can reult in destruction of wrong buffer after 401] Date: Sun, 17 Oct 2004 03:24:58 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1097997961 13225 80.91.229.6 (17 Oct 2004 07:26:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 17 Oct 2004 07:26:01 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 17 09:25:55 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CJ5QR-0002yX-00 for ; Sun, 17 Oct 2004 09:25:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CJ5Xf-0000Ki-UR for ged-emacs-devel@m.gmane.org; Sun, 17 Oct 2004 03:33:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CJ5X7-0008Tb-OP for emacs-devel@gnu.org; Sun, 17 Oct 2004 03:32:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CJ5X5-0008Rt-N5 for emacs-devel@gnu.org; Sun, 17 Oct 2004 03:32:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CJ5X5-0008RW-G3 for emacs-devel@gnu.org; Sun, 17 Oct 2004 03:32:47 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CJ5PW-00027t-Fq for emacs-devel@gnu.org; Sun, 17 Oct 2004 03:24:58 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1CJ5PW-0007pG-27; Sun, 17 Oct 2004 03:24:58 -0400 Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28499 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28499 Could someone take a look at what to do here? I am not sure whether this is still relevant--his suggestion seems to assume that url-http-handle-authentication returns a new buffer, but it does not appear to do that now. Would someone please DTRT and ack to me? ------- Start of forwarded message ------- To: bug-gnu-emacs@gnu.org From: Vivek Dasmohapatra Date: Tue, 28 Sep 2004 16:13:13 +0100 X-Scanner: exiscan *1CCJfG-0000T2-00*YBhr5NphPPU* (Zeus Technology Ltd) Subject: url libraries can reult in destruction of wrong buffer after 401 Sender: bug-gnu-emacs-bounces+rms=gnu.org@gnu.org X-Spam-Status: No, hits=0.5 required=5.0 tests=RCVD_IN_ORBS version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) This bug report will be sent to the Free Software Foundation, not to your local site managers! Please write in English, because the Emacs maintainers do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. In GNU Emacs 21.3.1 (i386-pc-linux-gnu, X toolkit) of 2004-08-26 on nessus, modified by Debian configured using `configure '--build=i386-linux' '--host=i386-linux' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--with-x=yes' '--with-x-toolkit=athena' '--without-toolkit-scroll-bars' 'CFLAGS=-DDEBIAN -g -O2' 'build_alias=i386-linux' 'host_alias=i386-linux'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: ja_JP value of $LC_CTYPE: ja_JP value of $LC_MESSAGES: en_GB value of $LC_MONETARY: en_GB value of $LC_NUMERIC: en_GB value of $LC_TIME: en_GB value of $LANG: ja_JP locale-coding-system: japanese-iso-8bit default-enable-multibyte-characters: t Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Fetching a url with url-retrieve can reult in an anrbitrary buffer being killed if a 401 (or possibly a 407) result is encountered: url-http-parse-headers calls url-http-handle-authentication, which can call url-retrieve. This results in the current buffer being killed, and a new http buffer being generated. However, when the old http buffer is killed, emacs picks the top buffer from the list as the new current buffer, so by the time we get to the end of url-http-parse-headers, _that_ buffer is marked as dead even though it is not necessarily a url buffer, so next time the url libraries reap their dead buffers, an innocent bystander buffer is killed instead (and an obsolete http buffer may be left lying around too). A possible fix (which I am currently using) is to call set-buffer on the return value of url-http-parse-headers: (case url-http-response-status (401 ;; The request requires user authentication. The response ;; MUST include a WWW-Authenticate header field containing a ;; challenge applicable to the requested resource. The ;; client MAY repeat the request with a suitable ;; Authorization header field. (url-mark-buffer-as-dead (current-buffer)) (set-buffer (url-http-handle-authentication nil))) etc .... which makes sure that it is the right http buffer that is current when we come to mark the http buffers as dead. _______________________________________________ Bug-gnu-emacs mailing list Bug-gnu-emacs@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs ------- End of forwarded message -------