From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [pogonyshev@gmx.net: `c-indent-command' in a rare case]
Date: Sun, 10 Oct 2004 11:16:22 -0400
Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Message-ID: <E1CGfQs-0002xb-2W@fencepost.gnu.org>
References: <E1CDv10-0004rX-Fw@fencepost.gnu.org>
	<5bvfdmzscy.fsf@lister.roxen.com>
	<E1CFxFI-0000Tl-Bd@fencepost.gnu.org>
	<m1vfdlp1dt.fsf-monnier+emacs@gnu.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1097421524 19762 80.91.229.6 (10 Oct 2004 15:18:44 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sun, 10 Oct 2004 15:18:44 +0000 (UTC)
Cc: bug-cc-mode@gnu.org, emacs-devel@gnu.org, pogonyshev@gmx.net
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 10 17:18:40 2004
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Original-Received: from lists.gnu.org ([199.232.76.165])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1CGfT6-0000Fm-00
	for <ged-emacs-devel@m.gmane.org>; Sun, 10 Oct 2004 17:18:40 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33)
	id 1CGfZz-00013Y-MK
	for ged-emacs-devel@m.gmane.org; Sun, 10 Oct 2004 11:25:47 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1CGfXy-0008GS-BT
	for emacs-devel@gnu.org; Sun, 10 Oct 2004 11:23:43 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1CGfXw-0008Ft-Fy
	for emacs-devel@gnu.org; Sun, 10 Oct 2004 11:23:40 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1CGfXw-0008Ff-9c
	for emacs-devel@gnu.org; Sun, 10 Oct 2004 11:23:40 -0400
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1CGfQs-0004fL-FY
	for emacs-devel@gnu.org; Sun, 10 Oct 2004 11:16:22 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1CGfQs-0002xb-2W; Sun, 10 Oct 2004 11:16:22 -0400
Original-To: Stefan <monnier@iro.umontreal.ca>
In-reply-to: <m1vfdlp1dt.fsf-monnier+emacs@gnu.org> (message from Stefan on
	Fri, 08 Oct 2004 13:29:00 -0400)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:28182
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28182

    Huh?  Contrary to skip-chars-forward, forward-line returns the number of
    lines remaining, not the "decrease in the number of lines remaining".
    I.e. (zerop (forward-line 1)) is often used to check that forward-line has
    indeed moved.

    I agree with Martin that it would be better to not return 0 when it has moved
    but hasn't managed to move to a different line.

Ok, I agree.

Would someone like to change this?

It is important to check that the various callers that look
at the return value will still work.  But I tend to think they
mostly will, because this change would increase the consistency
of the return value.