From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: did compilation-mode loose an arg? Date: Sun, 05 Sep 2004 13:25:28 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <413A5105.7060402@newsmonster.org> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1094405208 17906 80.91.224.253 (5 Sep 2004 17:26:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Sep 2004 17:26:48 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 05 19:26:41 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C40mn-0007GP-00 for ; Sun, 05 Sep 2004 19:26:41 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C40rv-0005LP-0N for ged-emacs-devel@m.gmane.org; Sun, 05 Sep 2004 13:31:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C40rk-0005Kv-RA for emacs-devel@gnu.org; Sun, 05 Sep 2004 13:31:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C40rk-0005KO-18 for emacs-devel@gnu.org; Sun, 05 Sep 2004 13:31:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C40rj-0005KL-Uh for emacs-devel@gnu.org; Sun, 05 Sep 2004 13:31:47 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C40lc-0002Tg-Ud for emacs-devel@gnu.org; Sun, 05 Sep 2004 13:25:29 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34) id 1C40lc-00082S-EY; Sun, 05 Sep 2004 13:25:28 -0400 Original-To: "Kevin A. Burton" In-reply-to: <413A5105.7060402@newsmonster.org> (burton@newsmonster.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26797 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26797 THis change should bring back the lost feature. Is it ok? Index: compile.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/progmodes/compile.el,v retrieving revision 1.327 diff -c -c -r1.327 compile.el *** compile.el 4 Sep 2004 12:47:21 -0000 1.327 --- compile.el 5 Sep 2004 17:10:54 -0000 *************** *************** *** 1103,1109 **** :version "21.4") ;;;###autoload ! (defun compilation-mode () "Major mode for compilation log buffers. \\To visit the source for a line-numbered error, move point to the error message line and type \\[compile-goto-error]. --- 1103,1109 ---- :version "21.4") ;;;###autoload ! (defun compilation-mode (&optional name-of-mode) "Major mode for compilation log buffers. \\To visit the source for a line-numbered error, move point to the error message line and type \\[compile-goto-error]. *************** *** 1116,1122 **** (kill-all-local-variables) (use-local-map compilation-mode-map) (setq major-mode 'compilation-mode ! mode-name "Compilation") (set (make-local-variable 'page-delimiter) compilation-page-delimiter) (compilation-setup) --- 1116,1122 ---- (kill-all-local-variables) (use-local-map compilation-mode-map) (setq major-mode 'compilation-mode ! mode-name (or name-of-mode "Compilation")) (set (make-local-variable 'page-delimiter) compilation-page-delimiter) (compilation-setup)