From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Preventing stack overflows with alloca.
Date: Tue, 22 Jun 2004 19:17:46 -0400
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <E1BcuWQ-0001nE-AJ@fencepost.gnu.org>
References: <m3smctxje6.fsf@kfs-l.imdomain.dk>
	<200406181113.UAA03743@etlken.m17n.org>
	<m3k6y5xefb.fsf@kfs-l.imdomain.dk>
	<E1BbWNv-0001Eh-Ms@fencepost.gnu.org>
	<m3smco605e.fsf@kfs-l.imdomain.dk>
Reply-To: rms@gnu.org
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1087946388 29053 80.91.224.253 (22 Jun 2004 23:19:48 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Tue, 22 Jun 2004 23:19:48 +0000 (UTC)
Cc: emacs-devel@gnu.org, handa@m17n.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jun 23 01:19:41 2004
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BcuYH-0006ZH-00
	for <emacs-devel@deer.gmane.org>; Wed, 23 Jun 2004 01:19:41 +0200
Original-Received: from lists.gnu.org ([199.232.76.165])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BcuYH-0006tt-00
	for <emacs-devel@quimby.gnus.org>; Wed, 23 Jun 2004 01:19:41 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33)
	id 1BcuZb-0002EH-OD
	for emacs-devel@quimby.gnus.org; Tue, 22 Jun 2004 19:21:03 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1BcuXs-0001BX-3t
	for emacs-devel@gnu.org; Tue, 22 Jun 2004 19:19:16 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1BcuXr-0001As-6T
	for emacs-devel@gnu.org; Tue, 22 Jun 2004 19:19:15 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1BcuXr-0001A6-2T
	for emacs-devel@gnu.org; Tue, 22 Jun 2004 19:19:15 -0400
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1BcuWR-0003mN-Hq
	for emacs-devel@gnu.org; Tue, 22 Jun 2004 19:17:47 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1BcuWQ-0001nE-AJ; Tue, 22 Jun 2004 19:17:46 -0400
Original-To: storm@cua.dk (Kim F. Storm)
In-reply-to: <m3smco605e.fsf@kfs-l.imdomain.dk> (storm@cua.dk)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:25193
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25193

    I installed the SAFE_ALLOCA macros, using the make_save_value approach.
    I also fixed the alloca uses that looked suspicious to me.

Thanks.

It seems like a good optimization to make safe_alloca_unwind explicitly
free the save-value object.  Want to do that?