From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: convert-standard-filename's doc
Date: Sat, 29 May 2004 13:02:27 -0400
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <E1BU7E3-0006fn-9S@fencepost.gnu.org>
References: <3099-Thu27May2004202140+0300-eliz@gnu.org>
	<jwvisehldws.fsf-monnier+emacs@gnu.org>
	<20040528092904.7532.JMBARRANQUERO@wke.es>
	<jwvhdu0jzgg.fsf-monnier+emacs@gnu.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: deer.gmane.org
X-Trace: sea.gmane.org 1085850177 10390 80.91.224.253 (29 May 2004 17:02:57 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Sat, 29 May 2004 17:02:57 +0000 (UTC)
Cc: jmbarranquero@wke.es, emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat May 29 19:02:51 2004
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BU7EQ-00079s-00
	for <emacs-devel@deer.gmane.org>; Sat, 29 May 2004 19:02:50 +0200
Original-Received: from lists.gnu.org ([199.232.76.165])
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1BU7EQ-0002Gg-00
	for <emacs-devel@quimby.gnus.org>; Sat, 29 May 2004 19:02:50 +0200
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33)
	id 1BU7EW-00075I-CB
	for emacs-devel@quimby.gnus.org; Sat, 29 May 2004 13:02:56 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1BU7EN-000750-9U
	for emacs-devel@gnu.org; Sat, 29 May 2004 13:02:47 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1BU7EM-00074f-F4
	for emacs-devel@gnu.org; Sat, 29 May 2004 13:02:46 -0400
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1BU7EM-00074O-7a
	for emacs-devel@gnu.org; Sat, 29 May 2004 13:02:46 -0400
Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1BU7E4-0001Na-K6
	for emacs-devel@gnu.org; Sat, 29 May 2004 13:02:28 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.34)
	id 1BU7E3-0006fn-9S; Sat, 29 May 2004 13:02:27 -0400
Original-To: Stefan Monnier <monnier@iro.umontreal.ca>
In-reply-to: <jwvhdu0jzgg.fsf-monnier+emacs@gnu.org> (message from Stefan
	Monnier on 28 May 2004 12:21:24 -0400)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.4
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:24174
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:24174

    > prefer to have a hook. Every time I have to redefine a function to
    > change some tiny think I'm afraid I'll accidentally miss fixes and
    > enhancements to the original function.

    Redefine with defadvice.  It's the only half-robust way to do it.

Ordinarily we have a rule that packages in Emacs should never use
defadvice.  However, in this particular case, I suppose using defadvice
is no worse than completely redefining the function.