From: Richard Stallman <rms@gnu.org>
Cc: emacs@whaite.ca, emacs-devel@gnu.org
Subject: Re: printing most-negative-fixnum fails
Date: Tue, 11 May 2004 08:23:31 -0400 [thread overview]
Message-ID: <E1BNWIF-0008SK-U1@fencepost.gnu.org> (raw)
In-Reply-To: <87vfj3g1kv.fsf@mail.jurta.org> (message from Juri Linkov on Tue, 11 May 2004 03:17:52 +0300)
> Minor annoyance is that evaluating most-negative-fixnum in *scratch*
> (Lisp Interaction mode) fails...
This bug is caused by calling `(downcase most-negative-fixnum)'
in `event-modifiers' called from `prin1-char'.
The bug exists because the range of integers is greater
and there are bits above the character flags. So I put the
change below into casefiddle.c.
I remember it was agreed some time ago that by default C-x C-e should
not display numbers as characters to avoid all related problems.
Who agreed on that?
It seems to me that this feature is useful and harmless, and that the
extra complexity of adding an option to disable it is not worth while.
We have to fix these bugs anyway, so the option won't save us any work.
*** casefiddle.c 11 Sep 2003 09:51:06 -0400 1.44
--- casefiddle.c 11 May 2004 08:04:28 -0400
***************
*** 52,57 ****
--- 52,63 ----
| CHAR_SHIFT | CHAR_CTL | CHAR_META);
int flags = XINT (obj) & flagbits;
+ /* If the character has higher bits set
+ above the flags, return it unchanged.
+ It is not a real character. */
+ if ((unsigned) XFASTINT (obj) > (unsigned) flagbits)
+ return obj;
+
c = DOWNCASE (XFASTINT (obj) & ~flagbits);
if (inword)
XSETFASTINT (obj, c | flags);
next prev parent reply other threads:[~2004-05-11 12:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 20:08 printing most-negative-fixnum fails Peter Whaite
2004-05-11 0:17 ` Juri Linkov
2004-05-11 3:20 ` Stefan Monnier
2004-05-11 16:57 ` Juri Linkov
2004-05-12 19:41 ` Richard Stallman
2004-05-11 12:23 ` Richard Stallman [this message]
2004-05-11 16:47 ` Juri Linkov
2004-05-14 9:20 ` Richard Stallman
2004-05-14 11:46 ` Kenichi Handa
2004-05-15 8:17 ` Juri Linkov
2004-05-15 8:53 ` Richard Stallman
2004-05-15 9:19 ` David Kastrup
2004-05-15 20:03 ` Juri Linkov
2004-05-18 13:03 ` Kenichi Handa
2004-05-19 8:36 ` Juri Linkov
2004-05-15 8:09 ` Juri Linkov
2004-05-15 18:34 ` Richard Stallman
2004-05-15 19:32 ` Juri Linkov
2004-05-12 1:41 ` Kenichi Handa
2004-05-12 2:06 ` Stefan Monnier
2004-05-12 4:43 ` Kenichi Handa
2004-05-11 2:48 ` Stefan Monnier
2004-05-11 3:11 ` Luc Teirlinck
2004-05-11 4:26 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1BNWIF-0008SK-U1@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=emacs@whaite.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).