From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: threaded code in bytecode.c Date: Mon, 03 May 2004 18:20:59 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20040503011011.GA16378@people.kldp.org> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1083623253 25066 80.91.224.253 (3 May 2004 22:27:33 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 May 2004 22:27:33 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 04 00:27:21 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKluD-0003kl-00 for ; Tue, 04 May 2004 00:27:21 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BKluC-00005P-00 for ; Tue, 04 May 2004 00:27:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKltw-0007xY-5b for emacs-devel@quimby.gnus.org; Mon, 03 May 2004 18:27:04 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BKlom-0005SP-93 for emacs-devel@gnu.org; Mon, 03 May 2004 18:21:44 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BKlo4-00056i-GP for emacs-devel@gnu.org; Mon, 03 May 2004 18:21:31 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BKlo4-000566-0j for emacs-devel@gnu.org; Mon, 03 May 2004 18:21:00 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.24) id 1BKlo3-0000N2-7V; Mon, 03 May 2004 18:20:59 -0400 Original-To: jay@kldp.org In-reply-to: <20040503011011.GA16378@people.kldp.org> (jay@people.kldp.org) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22655 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22655 the main possible benefit of this change is a speedup. How much speedup do you observe from it? It would be good to compare various GCC optimization levels as well as the two versions of the code. A large part of your change seems to be in the indentation of the #define's for bytecode operations. Please do not combine such a large cosmetic change with any substantive change. I think it is better to leave that indentation the way it is, but if we do change it, we should install that change separately.