From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: scroll-conservatively overflow
Date: Sat, 01 May 2004 13:50:51 -0400 [thread overview]
Message-ID: <E1BJydX-0001LF-V6@fencepost.gnu.org> (raw)
In-Reply-To: <87d65p1yxk.fsf@orebokech.com> (message from Romain Francoise on Fri, 30 Apr 2004 13:35:03 +0200)
2004-03-02 Richard M. Stallman <rms@gnu.org>
* indent.c (compute_motion): Save vpos in prev_vpos, like hpos etc.
Reverting this change (see attached patch) solves all issues in Dired,
Gnus, etc.
I have tried to come up with a fix but failed. I don't really
understand why this change was necessary, it adds complexity and does
not fix anything as far as I can see.
I made that change to fix a specific bug. That function was returning
incorrect results in a certain case. I don't remember the test case,
unfortunately.
This change also makes the function cleaner because it handles vpos
like the various other values.
Apparently the new code has another bug. That often happens. Could
you figure out precisely what the bug is? Then we could find the
right fix.
next prev parent reply other threads:[~2004-05-01 17:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 10:00 scroll-conservatively overflow Juanma Barranquero
2004-04-16 13:17 ` Kim F. Storm
2004-04-16 14:03 ` Romain Francoise
2004-04-30 11:35 ` Romain Francoise
2004-04-30 16:38 ` Kim F. Storm
2004-05-01 17:50 ` Richard Stallman [this message]
2004-05-02 12:37 ` Romain Francoise
2004-05-02 16:58 ` Stefan Monnier
2004-05-03 14:03 ` Richard Stallman
2004-04-17 19:42 ` Richard Stallman
2004-04-17 20:52 ` Juanma Barranquero
2004-04-18 21:31 ` Kim F. Storm
2004-04-19 11:37 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1BJydX-0001LF-V6@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).