From: Markus Rost <rost@mathematik.uni-bielefeld.de>
Cc: emacs-pretest-bug@gnu.org, eliz@elta.co.il,
monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Emacs 21.3.50 grep.el/executable.el problems
Date: Wed, 18 Feb 2004 21:55:59 +0100 [thread overview]
Message-ID: <E1AtYjf-0007fK-00@yui26.Mathematik.Uni-Bielefeld.DE> (raw)
In-Reply-To: <E1AtNEl-0004TN-Km@fencepost.gnu.org> (message from Richard Stallman on Wed, 18 Feb 2004 03:39:19 -0500)
another use of executable-command-find-posix-p, namely in
filecache.el. Maybe one should change that as well and then remove
executable-command-find-posix-p.
Someone said that filecache.el previously failed entirely to cope with
a nonstandard find, so perhaps we lose nothing by leaving it in
and we may as well fix it instead.
I just applied the following patch which ought to fix the mentioned
problems. It uses `file-truename' to avoid possible symlink problems.
===Buffer *vc-diff*=========================================
Index: executable.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/progmodes/executable.el,v
retrieving revision 1.30
retrieving revision 1.31
diff -c -r1.30 -r1.31
*** executable.el 1 Feb 2004 16:27:00 -0000 1.30
--- executable.el 18 Feb 2004 20:47:46 -0000 1.31
***************
*** 145,156 ****
"Check if PROGRAM handles arguments Posix-style.
If PROGRAM is non-nil, use that instead of \"find\"."
;; Pick file to search from location we know
! (let* ((dir (car load-path))
! (file (find-if
! (lambda (x)
! ;; Filter directories . and ..
! (not (string-match "^\\.\\.?$" x)))
! (directory-files dir))))
(with-temp-buffer
(call-process (or program "find")
nil
--- 145,152 ----
"Check if PROGRAM handles arguments Posix-style.
If PROGRAM is non-nil, use that instead of \"find\"."
;; Pick file to search from location we know
! (let* ((dir (file-truename data-directory))
! (file (car (directory-files dir nil "^[^.]"))))
(with-temp-buffer
(call-process (or program "find")
nil
============================================================
next prev parent reply other threads:[~2004-02-18 20:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-16 14:35 Emacs 21.3.50 grep.el/executable.el problems Markus Rost
2004-02-16 15:17 ` Ehud Karni
2004-02-16 16:14 ` Stefan Monnier
2004-02-16 19:57 ` Eli Zaretskii
2004-02-16 20:16 ` Stefan Monnier
2004-02-16 20:31 ` Jason Rumney
2004-02-16 21:10 ` Markus Rost
2004-02-17 6:34 ` Eli Zaretskii
2004-02-18 8:39 ` Richard Stallman
2004-02-18 20:55 ` Markus Rost [this message]
2004-02-17 17:27 ` Richard Stallman
2004-02-16 16:30 ` Kim F. Storm
2004-02-16 16:23 ` Markus Rost
-- strict thread matches above, loose matches on Subject: below --
2004-02-13 6:32 Emacs 21.3.50 on cygwin bootstrap failed. (Jason Rumney) Steven Wu
2004-02-14 15:04 ` Emacs 21.3.50 grep.el/executable.el problems Ehud Karni
2004-02-15 11:43 ` Ehud Karni
2004-02-15 12:59 ` Piet van Oostrum
2004-02-15 13:20 ` Thien-Thi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1AtYjf-0007fK-00@yui26.Mathematik.Uni-Bielefeld.DE \
--to=rost@mathematik.uni-bielefeld.de \
--cc=eliz@elta.co.il \
--cc=emacs-devel@gnu.org \
--cc=emacs-pretest-bug@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).