unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [matt@mundell.ukfsn.org: Shrinking side-by-side windows]
@ 2004-02-08 15:22 Richard Stallman
  0 siblings, 0 replies; only message in thread
From: Richard Stallman @ 2004-02-08 15:22 UTC (permalink / raw)


This looks like a real bug, but I suspect this is not the
whole fix.  Does someone want to fix this?

To: emacs-pretest-bug@gnu.org
From: Matthew Mundell <matt@mundell.ukfsn.org>
Date: 07 Feb 2004 15:21:28 +0000
Subject: Shrinking side-by-side windows
Sender: emacs-pretest-bug-bounces+rms=gnu.org@gnu.org

With the CVS Emacs, shrink-window-if-larger-than-buffer (C-x -)
shrinks a window when there is a window to its right and a single
window across the frame above it (or across the bottom of the frame if
it is the top-left window).

It seems that for a non-top-left window window-safely-shrinkable-p
only checks the previous window.  And when called without an argument
(as by shrink-window-if-larger-than-buffer) window-safely-shrinkable-p
treats the top-left window as any other window (checking the previous
window instead of only the next).  This could be changed follows.

===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/window.el,v
retrieving revision 1.92
diff -u -r1.92 window.el
--- window.el	24 Sep 2003 22:55:42 -0000	1.92
+++ window.el	5 Feb 2004 19:51:43 -0000
@@ -189,10 +189,14 @@
   "Non-nil if the WINDOW can be shrunk without shrinking other windows.
 If WINDOW is nil or omitted, it defaults to the currently selected window."
   (save-selected-window
-    (when window (select-window window))
+    (if window
+	(select-window window)
+      (setq window (selected-window)))
     (or (and (not (eq window (frame-first-window)))
 	     (= (car (window-edges))
-		(car (window-edges (previous-window)))))
+		(car (window-edges (previous-window))))
+ 	     (= (car (window-edges))
+ 		(car (window-edges (next-window)))))
 	(= (car (window-edges))
 	   (car (window-edges (next-window)))))))


_______________________________________________
Emacs-pretest-bug mailing list
Emacs-pretest-bug@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-pretest-bug

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-02-08 15:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-08 15:22 [matt@mundell.ukfsn.org: Shrinking side-by-side windows] Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).