[kzeitler@lucent.com: Re: compose key on SUN keyboard creates 2 characters (and beeps)]

[Richard Stallman <rms@gnu.org>]

Can somebody who knows these issues better than I do please think
about whether this is correct?

X-Authentication-Warning: sfsw51.de.lucent.com: kzeitler set sender to kzeitler@lucent.com using -f
To: rms@gnu.org
Subject: Re: compose key on SUN keyboard creates 2 characters (and beeps)
X-Emacs-Acronym: Every Moron Assumes CCA is Superior
From: Klaus Zeitler <kzeitler@lucent.com>
Date: 08 Jan 2004 10:15:58 +0100
In-Reply-To: <E1Aa5p5-00083M-Ob@fencepost.gnu.org>
X-Spam-Status: No, hits=-2.1 required=5.0
	tests=IN_REP_TO,PATCH_CONTEXT_DIFF,REFERENCES,USER_AGENT_GNUS_UA,
	      X_AUTH_WARNING
	version=2.55
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)

--=-=-=

>>>>> "Richard" == Richard Stallman <rms@gnu.org> writes:
    Richard> 
    Richard> Could you tell me if this change is still needed?
    Richard> If it is, could you send a diff -c so I can be sure to
    Richard> make the change right?

yes, it's still needed. Here's a patch that works for Solaris.
Don't know about other OS.

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment; filename=compose-key.patch
Content-Description: patch for compose key handling in xterm.c

*** xterm.c	Thu Jan  8 09:31:58 2004
--- xterm.c.~1.823.~	Thu Jan  8 09:31:00 2004
***************
*** 6305,6316 ****
                                    &compose_status);
  #endif
  
- 	  /* Check if we're processing a composed key. In this case we need
- 	     3 key presses till the key is complete. */
- 	  if ((compose_status.chars_matched == 1) ||
- 	      (compose_status.chars_matched == 2))
- 	    goto OTHER;
- 
            orig_keysym = keysym;
  
            if (numchars > 1)
--- 6305,6310 ----

--=-=-=


as I said in my original post instead of these lines it also works if one
checks nbytes instead, i.e.
--- snip ---
	  if (nbytes <= 0)
	    goto OTHER;
--- snip ---
should also work.

Since you asked if this is still needed I'm guessing that the compose key
works for other operating systems, e.g. GNU/Linux. Is that so?

Klaus

-- 
 ------------------------------------------
|  Klaus Zeitler      Lucent Technologies  |
|  Email:             kzeitler@lucent.com  |
 ------------------------------------------
---
Early to rise, and early to bed / Makes a man healthy but socially dead
--=-=-=--