From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: No GCPRO in directory-files and directory-files-and-attributes Date: Tue, 09 Dec 2003 16:49:46 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <3FCBC193.2080509@math.ku.dk> Reply-To: rms@gnu.org NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1071007039 28984 80.91.224.253 (9 Dec 2003 21:57:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Dec 2003 21:57:19 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Dec 09 22:57:12 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1ATpqy-0002kY-00 for ; Tue, 09 Dec 2003 22:57:12 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1ATpqy-0001Aq-00 for ; Tue, 09 Dec 2003 22:57:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ATqn4-00048u-1b for emacs-devel@quimby.gnus.org; Tue, 09 Dec 2003 17:57:14 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ATqk9-00033Y-7J for emacs-devel@gnu.org; Tue, 09 Dec 2003 17:54:13 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1ATqjH-0002WE-Qv for emacs-devel@gnu.org; Tue, 09 Dec 2003 17:53:50 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ATqiG-0001rk-Iw for emacs-devel@gnu.org; Tue, 09 Dec 2003 17:52:16 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.24) id 1ATpjm-0000NV-Mz; Tue, 09 Dec 2003 16:49:46 -0500 Original-To: Lars Hansen In-reply-to: <3FCBC193.2080509@math.ku.dk> (message from Lars Hansen on Mon, 01 Dec 2003 23:32:51 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:18583 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:18583 In dired.c I have noticed that file name handlers are called using the function call from eval.c. However, there are two exceptions, the calls in functions Fdirectory-files and Fdirectory-files-and-attributes where Ffuncall is used instead. This means that the arguments are not protected with GCPRO. Calling call1 etc. does not GCPRO the variables from which the argument values are obtained, any more than calling Ffuncall does. When calling Ffuncall, you need to GCPRO the vector of arguments, but only if the values are live. Is this intensional or is it a bug? I don't think there is a bug. Those values will never be used again, so they don't need to be GCPRO'd.