Suggestion: go to bottom of mail message

Suggestion: go to bottom of mail message

[Ehud Karni]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I recently noticed that I frequently need to go to the end of a mail
message, so I wrote `rmail-summary-end-of-message' and assigned it
to ";" in `rmail-summary-mode-map'. In the process I noticed that
`rmail-summary-beginning-of-message' uses (beginning-of-buffer) so I
changed it to (goto-char (point-min)).

Ehud.


2003-11-19  Ehud Karni  <ehud@unix.mvs.co.il>

	* mail/rmailsum.el (rmail-summary-end-of-message): New command
	to go to the bottom of the mail message.
	Added to `rmail-summary-mode-map' with key ";".
	(rmail-summary-beginning-of-message) minor improvement.



cd /lnx1/gnu/src/emacs/lisp/mail/
diff -c /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el_org /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el
*** /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el_org	Wed Nov 19 12:48:01 2003
- --- /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el	Wed Nov 19 12:59:36 2003
***************
*** 890,895 ****
- --- 890,896 ----
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      'rmail-summary-beginning-of-message)
+   (define-key rmail-summary-mode-map ";"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
***************
*** 1191,1197 ****
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (beginning-of-buffer)
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
- --- 1192,1216 ----
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (goto-char (point-min))
!   (pop-to-buffer rmail-summary-buffer))
!
! (defun rmail-summary-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (if (and (one-window-p) (not pop-up-frames))
!       ;; If there is just one window, put the summary on the top.
!       (let ((buffer rmail-view-buffer))
! 	(split-window (selected-window) rmail-summary-window-size)
! 	(select-window (frame-first-window))
! 	(pop-to-buffer rmail-view-buffer)
! 	;; If pop-to-buffer did not use that window, delete that
! 	;; window.  (This can happen if it uses another frame.)
! 	(or (eq buffer (window-buffer (next-window (frame-first-window))))
! 	    (delete-other-windows)))
!     (pop-to-buffer rmail-view-buffer))
!   (goto-char (point-max))
!   (recenter (window-height))
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()

Diff finished at Wed Nov 19 13:00:29


- --
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry
-----BEGIN PGP SIGNATURE-----
Comment: use http://www.keyserver.net/ to get my key (and others)

iD8DBQE/u1NoLFvTvpjqOY0RAvkuAKCDSRKPm8TtoNmRUVjG4aL/BRVi3wCePjc7
8MJQX1Hkwmlp8hCxdP44Cyo=
=e2hi
-----END PGP SIGNATURE-----

Re: Suggestion: go to bottom of mail message

[Kenichi Handa]

In article <200311191126.hAJBQY6C008722@beta.mvs.co.il>, "Ehud Karni" <ehud@unix.mvs.co.il> writes:
> I recently noticed that I frequently need to go to the end of a mail
> message, so I wrote `rmail-summary-end-of-message' and assigned it
> to ";" in `rmail-summary-mode-map'. In the process I noticed that
> `rmail-summary-beginning-of-message' uses (beginning-of-buffer) so I
> changed it to (goto-char (point-min)).

I like the idea of the new command
rmail-summary-end-of-message too.

Three points:

(1) How about also making the new command
rmail-end-of-message in RMAIL mode.

(2) I've just noticed that
rmail-summary-beginning-of-message works slightly
differently than rmail-beginnig-of-message.  The formar
moves point to the really beginning of a message, but the
latter moves point to the beginning of a BODY of a message.
I think the latter is better because the former can be done
by ESC <.  So, shouldn't we change
rmail-summary-beginning-of-message?

(3) I prefer the key "/" than ";" for
rmail[-summary]-end-of-message because "/" is usually just
right of "." but ";" is usually right upper of ".".  As "."
moves point to the beggining, it seems strange to type the
upper key to move point to the end.  By the way, for me the
ideal keys are:
  "," go to the beginning
  "." go to the end
because my fingers already got used to "ESC <" and "ESC >",
and "," and "<", "." and ">" are on the same keys.

---
Ken'ichi HANDA
handa@m17n.org

Re: Suggestion: go to bottom of mail message

[Kim F. Storm]

Kenichi Handa <handa@m17n.org> writes:

> (3) I prefer the key "/" than ";" for
> rmail[-summary]-end-of-message because "/" is usually just
> right of "." but ";" is usually right upper of ".".  As "."
> moves point to the beggining, it seems strange to type the
> upper key to move point to the end.  By the way, for me the
> ideal keys are:
>   "," go to the beginning
>   "." go to the end
> because my fingers already got used to "ESC <" and "ESC >",
> and "," and "<", "." and ">" are on the same keys.

I don't use rmail anymore, but as a general note, you should
not make decisions like this based on a specific keyboard layout.

For example, on a Danish PC keyboard, the three keys to the right of
"M" produces the following characters (shifted in the first row):

        ;  :  _
        ,  .  -

while < and > are on a separate key, and / is above 7.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Suggestion: go to bottom of mail message

[Juri Linkov]

storm@cua.dk (Kim F. Storm) writes:
> Kenichi Handa <handa@m17n.org> writes:
>> (3) I prefer the key "/" than ";" for
>> rmail[-summary]-end-of-message because "/" is usually just
>> right of "." but ";" is usually right upper of ".".  As "."
>> moves point to the beggining, it seems strange to type the
>> upper key to move point to the end.  By the way, for me the
>> ideal keys are:
>>   "," go to the beginning
>>   "." go to the end
>> because my fingers already got used to "ESC <" and "ESC >",
>> and "," and "<", "." and ">" are on the same keys.
>
> I don't use rmail anymore, but as a general note, you should
> not make decisions like this based on a specific keyboard layout.
>
> For example, on a Danish PC keyboard, the three keys to the right of
> "M" produces the following characters (shifted in the first row):
>
>         ;  :  _
>         ,  .  -
>
> while < and > are on a separate key, and / is above 7.

Right, my Swedish/Finnish keyboard has the same layout.  But still
keys "," and "." are located on the same positions on both layouts
(two keys to the right of "M").  However, I suggest to make
keybindings similar to those provided by Gnus.  They are very handy.

    "<" go to the beginning of message
    ">" go to the end of message
    "M-<" go to the first message
    "M->" go to the last message

-- 
http://www.jurta.org/emacs/

Re: Suggestion: go to bottom of mail message

[Ehud Karni]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 19 Nov 2003 20:55:07 +0900 (JST), Kenichi Handa <handa@m17n.org> wrote:
>
> (1) How about also making the new command
> rmail-end-of-message in RMAIL mode.

OK. See new patch below.

> (2) I've just noticed that
> rmail-summary-beginning-of-message works slightly
> differently than rmail-beginnig-of-message.  The formar
> moves point to the really beginning of a message, but the
> latter moves point to the beginning of a BODY of a message.
> I think the latter is better because the former can be done
> by ESC <.  So, shouldn't we change
> rmail-summary-beginning-of-message?

The rmail-beginning-of-message does not do that. May be you have
something in your `rmail-show-message-hook'. I think that putting
point at the beginning of the BODY is a good idea, so I changed
my code to do this.

> (3) I prefer the key "/" than ";" for
> rmail[-summary]-end-of-message because "/" is usually just
> right of "." but ";" is usually right upper of ".".  As ".
> moves point to the beggining, it seems strange to type the
> upper key to move point to the end.  By the way, for me the
> ideal keys are:
>   "," go to the beginning
>   "." go to the end
> because my fingers already got used to "ESC <" and "ESC >",
> and "," and "<", "." and ">" are on the same keys.

I changed the ";" to "/", but I don't take it upon myself to change
old key bindings (besides, see Kim mail about keyboards layout).

Ehud.


2003-11-19  Ehud Karni  <ehud@unix.mvs.co.il>

	* mail/rmailsum.el (rmail-summary-end-of-message): New command
	to go to the bottom of the mail message. Added to
	`rmail-summary-mode-map' with key "/".
        (rmail-summary-show-message) New (internal) function for use by
	both `rmail-summary-beginning/end-of-message'.
	(rmail-summary-beginning-of-message) Changed to use the new
	function and put the point at the beginning of the message BODY.

	* mail/rmail.el (rmail-end-of-message): New command to go to the
	end of the current message. Added to `rmail-mode-map' with key "/".
	(rmail-beginning-of-message): Changed to position point to the
	beginning of the BODY. (rmail-mode): change documentation.


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el_org
*** /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el	Wed Nov 19 15:03:15 2003
- --- /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el.~1.131.~	Wed Nov 19 12:48:01 2003
***************
*** 890,896 ****
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      'rmail-summary-beginning-of-message)
- -   (define-key rmail-summary-mode-map "/"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
- --- 890,895 ----
***************
*** 1181,1196 ****
  (defun rmail-summary-beginning-of-message ()
    "Show current message from the beginning."
    (interactive)
- -   (rmail-summary-show-message 'BEG))
- -
- - (defun rmail-summary-end-of-message ()
- -   "Show bottom of current message."
- -   (interactive)
- -   (rmail-summary-show-message 'END))
- -
- - (defun rmail-summary-show-message (where)
- -   "Show current mail message.
- - Position it according to WHERE which can be BEG or END"
    (if (and (one-window-p) (not pop-up-frames))
        ;; If there is just one window, put the summary on the top.
        (let ((buffer rmail-view-buffer))
- --- 1180,1185 ----
***************
*** 1202,1215 ****
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (cond
!    ((eq where 'BEG)
! 	(goto-char (point-min))
! 	(search-forward "\n\n"))
!    ((eq where 'END)
! 	(goto-char (point-max))
! 	(recenter (1- (window-height))))
!    )
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
- --- 1191,1197 ----
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (beginning-of-buffer)
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()

Diff finished at Wed Nov 19 16:56:09


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmail.el /lnx1/gnu/src/emacs/lisp/mail/rmail.el_org
*** /lnx1/gnu/src/emacs/lisp/mail/rmail.el	Wed Nov 19 16:29:56 2003
- --- /lnx1/gnu/src/emacs/lisp/mail/rmail.el.~1.376.~	Wed Nov 19 12:48:00 2003
***************
*** 848,854 ****
    (define-key rmail-mode-map "w"      'rmail-output-body-to-file)
    (define-key rmail-mode-map "x"      'rmail-expunge)
    (define-key rmail-mode-map "."      'rmail-beginning-of-message)
- -   (define-key rmail-mode-map "/"      'rmail-end-of-message)
    (define-key rmail-mode-map "<"      'rmail-first-message)
    (define-key rmail-mode-map ">"      'rmail-last-message)
    (define-key rmail-mode-map " "      'scroll-up)
- --- 848,853 ----
***************
*** 993,1000 ****
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message body.
! \\[rmail-end-of-message]	Move point to bottom of this message.
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
- --- 992,998 ----
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message (same as \\[beginning-of-buffer]).
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
***************
*** 2429,2452 ****
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (let ((rmail-show-message-hook
! 	 (append rmail-show-message-hook
! 	       (list (function (lambda ()
! 				 (search-forward "\n\n")))))))
!     (rmail-show-message rmail-current-message)))
!
! (defun rmail-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (let ((rmail-show-message-hook
! 	 (append rmail-show-message-hook
! 	       (list (function (lambda ()
! 				 (goto-char (point-max))
! 				 (recenter (1- (window-height)))))))))
!   (rmail-show-message rmail-current-message)))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.
- --- 2427,2433 ----
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (rmail-show-message rmail-current-message))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.

Diff finished at Wed Nov 19 17:05:10


- --
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry
-----BEGIN PGP SIGNATURE-----
Comment: use http://www.keyserver.net/ to get my key (and others)

iD8DBQE/u4u2LFvTvpjqOY0RAnkAAJ0S2uz4lRdhhHoHJYMaJ/U8gRlyCgCfeRdO
1Gg8Issf/sYnH2n03piO2L8=
=0Iz0
-----END PGP SIGNATURE-----

Re: Suggestion: go to bottom of mail message

[Ehud Karni]

My last post had a possible bug. Here is the fixed patch.
I also turned off the GPG signing because it distorts the patches.

Ehud.


2003-11-19  Ehud Karni  <ehud@unix.mvs.co.il>

	* mail/rmailsum.el (rmail-summary-end-of-message): New command
	to go to the bottom of the mail message. Added to
	`rmail-summary-mode-map' with key "/".
        (rmail-summary-show-message) New (internal) function for use by
	both `rmail-summary-beginning/end-of-message'.
	(rmail-summary-beginning-of-message) Changed to use the new
	function and put the point at the beginning of the message BODY.

	* mail/rmail.el (rmail-end-of-message): New command to go to the
	end of the current message. Added to `rmail-mode-map' with key "/".
	(rmail-beginning-of-message): Changed to position point to the
	beginning of the BODY. (rmail-mode): change documentation.


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el.\~1.131.\~
*** /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el	Wed Nov 19 15:03:15 2003
--- /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el.~1.131.~	Wed Nov 19 12:48:01 2003
***************
*** 890,896 ****
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      'rmail-summary-beginning-of-message)
-   (define-key rmail-summary-mode-map "/"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
--- 890,895 ----
***************
*** 1181,1196 ****
  (defun rmail-summary-beginning-of-message ()
    "Show current message from the beginning."
    (interactive)
-   (rmail-summary-show-message 'BEG))
-
- (defun rmail-summary-end-of-message ()
-   "Show bottom of current message."
-   (interactive)
-   (rmail-summary-show-message 'END))
-
- (defun rmail-summary-show-message (where)
-   "Show current mail message.
- Position it according to WHERE which can be BEG or END"
    (if (and (one-window-p) (not pop-up-frames))
        ;; If there is just one window, put the summary on the top.
        (let ((buffer rmail-view-buffer))
--- 1180,1185 ----
***************
*** 1202,1215 ****
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (cond
!    ((eq where 'BEG)
! 	(goto-char (point-min))
! 	(search-forward "\n\n"))
!    ((eq where 'END)
! 	(goto-char (point-max))
! 	(recenter (1- (window-height))))
!    )
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
--- 1191,1197 ----
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (beginning-of-buffer)
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()

Diff finished at Wed Nov 19 18:07:29


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmail.el /lnx1/gnu/src/emacs/lisp/mail/rmail.el.\~1.376.\~
*** /lnx1/gnu/src/emacs/lisp/mail/rmail.el	Wed Nov 19 18:01:13 2003
--- /lnx1/gnu/src/emacs/lisp/mail/rmail.el.~1.376.~	Wed Nov 19 12:48:00 2003
***************
*** 848,854 ****
    (define-key rmail-mode-map "w"      'rmail-output-body-to-file)
    (define-key rmail-mode-map "x"      'rmail-expunge)
    (define-key rmail-mode-map "."      'rmail-beginning-of-message)
-   (define-key rmail-mode-map "/"      'rmail-end-of-message)
    (define-key rmail-mode-map "<"      'rmail-first-message)
    (define-key rmail-mode-map ">"      'rmail-last-message)
    (define-key rmail-mode-map " "      'scroll-up)
--- 848,853 ----
***************
*** 993,1000 ****
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message body.
! \\[rmail-end-of-message]	Move point to bottom of this message.
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
--- 992,998 ----
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message (same as \\[beginning-of-buffer]).
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
***************
*** 2429,2450 ****
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (let ((rmail-show-message-hook
! 	 (append rmail-show-message-hook
! 	       (list (function (lambda ()
! 				 (goto-char (point-min))
! 				 (search-forward "\n\n")))))))
!     (rmail-show-message rmail-current-message)))
!
! (defun rmail-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (let ((rmail-show-message-hook
! 	 (append rmail-show-message-hook
! 	       (list (function (lambda ()
! 				 (goto-char (point-max))
! 				 (recenter (1- (window-height)))))))))
!   (rmail-show-message rmail-current-message)))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.
--- 2427,2433 ----
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (rmail-show-message rmail-current-message))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.

Diff finished at Wed Nov 19 18:01:44


--
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry

Re: Suggestion: go to bottom of mail message

[Richard Stallman]

    (2) I've just noticed that
    rmail-summary-beginning-of-message works slightly
    differently than rmail-beginnig-of-message.  The formar
    moves point to the really beginning of a message, but the
    latter moves point to the beginning of a BODY of a message.


When I try it, rmail-beginnig-of-message puts point at the real
beginning of the message.  I think it is better not to change that.

Re: Suggestion: go to bottom of mail message

[Kenichi Handa]

In article <E1AMg5B-0007Dx-Bd@fencepost.gnu.org>, Richard Stallman <rms@gnu.org> writes:

>     (2) I've just noticed that
>     rmail-summary-beginning-of-message works slightly
>     differently than rmail-beginnig-of-message.  The formar
>     moves point to the really beginning of a message, but the
>     latter moves point to the beginning of a BODY of a message.

> When I try it, rmail-beginnig-of-message puts point at the real
> beginning of the message.  I think it is better not to change that.

Sorry, it was my mistake.   I was using rmail-mime package
which makes that function behave differently.

---
Ken'ichi HANDA
handa@m17n.org

Re: Suggestion: go to bottom of mail message

[Kenichi Handa]

In article <m365hgxwyb.fsf@kfs-l.imdomain.dk>, storm@cua.dk (Kim F. Storm) writes:

> Kenichi Handa <handa@m17n.org> writes:
>>  (3) I prefer the key "/" than ";" for
>>  rmail[-summary]-end-of-message because "/" is usually just
>>  right of "." but ";" is usually right upper of ".".  As "."
>>  moves point to the beggining, it seems strange to type the
>>  upper key to move point to the end.  By the way, for me the
>>  ideal keys are:
>>    "," go to the beginning
>>    "." go to the end
>>  because my fingers already got used to "ESC <" and "ESC >",
>>  and "," and "<", "." and ">" are on the same keys.

> I don't use rmail anymore, but as a general note, you should
> not make decisions like this based on a specific keyboard layout.

Of course.  That's why I used the word "I prefer",
"usually", "for me ...".  But, we must give some default,
and it seems reasonable to decide it based on us-ascii
keyboard in the case that mnemonics doesn't work.

---
Ken'ichi HANDA
handa@m17n.org

Re: Suggestion: go to bottom of mail message

[Richard Stallman]

	    (rmail-beginning-of-message): Changed to position point to the
	    beginning of the BODY.

I don't think I want that change.

	    (rmail-beginning-of-message): Changed to position point to the
	    beginning of the BODY. (rmail-mode): change documentation.

Be careful, this change log is not formatted right!

Re: Suggestion: go to bottom of mail message

[Ehud Karni]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Thu, 20 Nov 2003 23:08:48 -0500, Richard Stallman <rms@gnu.org> wrote:
>
> 	    (rmail-beginning-of-message): Changed to position point to the
> 	    beginning of the BODY.
>
> I don't think I want that change.

Restored original behavior.

> 	    (rmail-beginning-of-message): Changed to position point to the
> 	    beginning of the BODY. (rmail-mode): change documentation.
>
> Be careful, this change log is not formatted right!

Fixed.



2003-11-21  Ehud Karni  <ehud@unix.mvs.co.il>

	* mail/rmailsum.el (rmail-summary-end-of-message): New command
	to go to the bottom of the mail message. Added to
	`rmail-summary-mode-map' with key "/".
        (rmail-summary-show-message) New (internal) function for use by
	both `rmail-summary-beginning/end-of-message'.
	(rmail-summary-beginning-of-message) Changed to use the new
	function.

	* mail/rmail.el (rmail-end-of-message): New command to go to the
	end of the current message. Added to `rmail-mode-map' with key "/".
        (rmail-beginning-of-message): Fixed a minor bug, disregard
	positioning by `rmail-show-message-hook'.
	(rmail-mode): `rmail-end-of-message' added to the documentation


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el.\~1.131.\~ /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el
*** /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el.~1.131.~	Wed Nov 19 12:48:01 2003
- --- /lnx1/gnu/src/emacs/lisp/mail/rmailsum.el	Fri Nov 21 08:51:50 2003
***************
*** 890,895 ****
- --- 890,896 ----
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      'rmail-summary-beginning-of-message)
+   (define-key rmail-summary-mode-map "/"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
***************
*** 1180,1185 ****
- --- 1181,1196 ----
  (defun rmail-summary-beginning-of-message ()
    "Show current message from the beginning."
    (interactive)
+   (rmail-summary-show-message 'BEG))
+
+ (defun rmail-summary-end-of-message ()
+   "Show bottom of current message."
+   (interactive)
+   (rmail-summary-show-message 'END))
+
+ (defun rmail-summary-show-message (where)
+   "Show current mail message.
+ Position it according to WHERE which can be BEG or END"
    (if (and (one-window-p) (not pop-up-frames))
        ;; If there is just one window, put the summary on the top.
        (let ((buffer rmail-view-buffer))
***************
*** 1191,1197 ****
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (beginning-of-buffer)
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
- --- 1202,1214 ----
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (cond
!    ((eq where 'BEG)
! 	(goto-char (point-min)))
!    ((eq where 'END)
! 	(goto-char (point-max))
! 	(recenter (1- (window-height))))
!    )
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()

Diff finished at Fri Nov 21 09:08:03


diff -c /lnx1/gnu/src/emacs/lisp/mail/rmail.el.\~1.376.\~ /lnx1/gnu/src/emacs/lisp/mail/rmail.el
*** /lnx1/gnu/src/emacs/lisp/mail/rmail.el.~1.376.~	Wed Nov 19 12:48:00 2003
- --- /lnx1/gnu/src/emacs/lisp/mail/rmail.el	Fri Nov 21 09:00:12 2003
***************
*** 848,853 ****
- --- 848,854 ----
    (define-key rmail-mode-map "w"      'rmail-output-body-to-file)
    (define-key rmail-mode-map "x"      'rmail-expunge)
    (define-key rmail-mode-map "."      'rmail-beginning-of-message)
+   (define-key rmail-mode-map "/"      'rmail-end-of-message)
    (define-key rmail-mode-map "<"      'rmail-first-message)
    (define-key rmail-mode-map ">"      'rmail-last-message)
    (define-key rmail-mode-map " "      'scroll-up)
***************
*** 993,998 ****
- --- 994,1000 ----
  Instead, these commands are available:

  \\[rmail-beginning-of-message]	Move point to front of this message (same as \\[beginning-of-buffer]).
+ \\[rmail-end-of-message]	Move point to bottom of this message.
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
***************
*** 2427,2433 ****
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (rmail-show-message rmail-current-message))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.
- --- 2429,2449 ----
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (let ((rmail-show-message-hook
! 	 (append rmail-show-message-hook
! 	       (list (function (lambda ()
! 				 (goto-char (point-min))))))))
!     (rmail-show-message rmail-current-message)))
!
! (defun rmail-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (let ((rmail-show-message-hook
! 	 (append rmail-show-message-hook
! 	       (list (function (lambda ()
! 				 (goto-char (point-max))
! 				 (recenter (1- (window-height)))))))))
!   (rmail-show-message rmail-current-message)))

  (defun rmail-show-message (&optional n no-summary)
    "Show message number N (prefix argument), counting from start of file.

Diff finished at Fri Nov 21 09:09:12


- --
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry
-----BEGIN PGP SIGNATURE-----
Comment: use http://www.keyserver.net/ to get my key (and others)

iD8DBQE/vbv1LFvTvpjqOY0RAt54AJ0TbeDMc5FL+gjlKEXXkdZNyl/1RwCdEEGj
0chb3qO2whhUDXJ4ZlZ1PBw=
=Yv96
-----END PGP SIGNATURE-----

Suggestion: go to bottom of mail message

[Ehud Karni]

On 2003-11-19 I suggested some change to mail/rmailsum.el (see -
http://lists.gnu.org/archive/html/emacs-devel/2003-11/msg00279.html )
that got a supporting opinion from Kenichi Handa (see -
http://lists.gnu.org/archive/html/emacs-devel/2003-11/msg00270.html ).
I don't have write permission to CVS and nobody else added it.
Here it is again (diff against the latest CVS versions), in the hope
that it will included in Emacs 22.1.

Ehud.


2003-11-19  Ehud Karni  <ehud@unix.mvs.co.il>

	* mail/rmailsum.el (rmail-summary-end-of-message): New command
	to go to the bottom of the mail message. Added to
	`rmail-summary-mode-map' with key "/".
        (rmail-summary-show-message) New (internal) function for use by
	both `rmail-summary-beginning/end-of-message'.
	(rmail-summary-beginning-of-message) Changed to use the new
	function.

	* mail/rmail.el (rmail-end-of-message): New command to go to the
	end of the current message. Added to `rmail-mode-map' with key "/".
	(rmail-beginning-of-message): Fixed to work as documented.
	(rmail-mode): change documentation.


diff -c /appl/src/emacs/lisp/mail/rmailsum-new.el /appl/src/emacs/lisp/mail/rmailsum.el.\~1.135.\~
*** /appl/src/emacs/lisp/mail/rmailsum-new.el	Sat Aug  6 12:30:10 2005
--- /appl/src/emacs/lisp/mail/rmailsum.el.~1.135.~	Mon Jul 11 19:05:43 2005
***************
*** 898,904 ****
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      'rmail-summary-beginning-of-message)
-   (define-key rmail-summary-mode-map "/"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
--- 898,903 ----
***************
*** 1186,1201 ****
  (defun rmail-summary-beginning-of-message ()
    "Show current message from the beginning."
    (interactive)
-   (rmail-summary-show-message 'BEG))
-
- (defun rmail-summary-end-of-message ()
-   "Show bottom of current message."
-   (interactive)
-   (rmail-summary-show-message 'END))
-
- (defun rmail-summary-show-message (where)
-   "Show current mail message.
- Position it according to WHERE which can be BEG or END"
    (if (and (one-window-p) (not pop-up-frames))
        ;; If there is just one window, put the summary on the top.
        (let ((buffer rmail-view-buffer))
--- 1185,1190 ----
***************
*** 1207,1220 ****
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (cond
!    ((eq where 'BEG)
! 	(goto-char (point-min))
! 	(search-forward "\n\n"))
!    ((eq where 'END)
! 	(goto-char (point-max))
! 	(recenter (1- (window-height))))
!    )
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
--- 1196,1203 ----
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (with-no-warnings
!     (beginning-of-buffer))
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()

Diff finished.  Sat Aug  6 12:48:40 2005


diff -c /appl/src/emacs/lisp/mail/rmail-new.el /appl/src/emacs/lisp/mail/rmail.el.\~1.406.\~
*** /appl/src/emacs/lisp/mail/rmail-new.el	Sat Aug  6 12:33:08 2005
--- /appl/src/emacs/lisp/mail/rmail.el.~1.406.~	Mon Jul 11 19:05:42 2005
***************
*** 952,958 ****
    (define-key rmail-mode-map "w"      'rmail-output-body-to-file)
    (define-key rmail-mode-map "x"      'rmail-expunge)
    (define-key rmail-mode-map "."      'rmail-beginning-of-message)
-   (define-key rmail-mode-map "/"      'rmail-end-of-message)
    (define-key rmail-mode-map "<"      'rmail-first-message)
    (define-key rmail-mode-map ">"      'rmail-last-message)
    (define-key rmail-mode-map " "      'scroll-up)
--- 952,957 ----
***************
*** 1097,1104 ****
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message.
! \\[rmail-end-of-message]	Move point to bottom of this message.
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
--- 1096,1102 ----
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message (same as \\[beginning-of-buffer]).
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
***************
*** 2606,2624 ****
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (let ((rmail-show-message-hook
! 	 (list (function (lambda ()
! 			   (goto-char (point-min)))))))
!     (rmail-show-message rmail-current-message)))
!
! (defun rmail-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (let ((rmail-show-message-hook
! 	 (list (function (lambda ()
! 			   (goto-char (point-max))
! 			   (recenter (1- (window-height))))))))
!     (rmail-show-message rmail-current-message)))

  (defun rmail-unknown-mail-followup-to ()
    "Handle a \"Mail-Followup-To\" header field with an unknown mailing list.
--- 2604,2610 ----
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (rmail-show-message rmail-current-message))

  (defun rmail-unknown-mail-followup-to ()
    "Handle a \"Mail-Followup-To\" header field with an unknown mailing list.

Diff finished.  Sat Aug  6 12:49:43 2005


--
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry

Suggestion: go to bottom of mail message

[Ehud Karni]

[this is resend because the attached patch had the files reversed]

On 2003-11-19 I suggested some change to mail/rmailsum.el (see -
http://lists.gnu.org/archive/html/emacs-devel/2003-11/msg00279.html )
that got a supporting opinion from Kenichi Handa (see -
http://lists.gnu.org/archive/html/emacs-devel/2003-11/msg00270.html ).
I don't have write permission to CVS and nobody else added it.
Here it is again (diff against the latest CVS versions), in the hope
that it will included in Emacs 22.1.

Ehud.


2003-11-19  Ehud Karni  <ehud@unix.mvs.co.il>

	* mail/rmailsum.el (rmail-summary-end-of-message): New command
	to go to the bottom of the mail message. Added to
	`rmail-summary-mode-map' with key "/".
        (rmail-summary-show-message) New (internal) function for use by
	both `rmail-summary-beginning/end-of-message'.
	(rmail-summary-beginning-of-message) Changed to use the new
	function.

	* mail/rmail.el (rmail-end-of-message): New command to go to the
	end of the current message. Added to `rmail-mode-map' with key "/".
	(rmail-beginning-of-message): Fixed to work as documented.
	(rmail-mode): change documentation.


diff -c rmailsum.el.~1.135.~ rmailsum-new.el
*** rmailsum.el.~1.135.~	Mon Jul 11 19:05:43 2005
--- rmailsum-new.el	Sat Aug  6 12:30:10 2005
***************
*** 898,903 ****
--- 898,904 ----
    (define-key rmail-summary-mode-map "x"      'rmail-summary-expunge)
    (define-key rmail-summary-mode-map "w"      'rmail-summary-output-body)
    (define-key rmail-summary-mode-map "."      'rmail-summary-beginning-of-message)
+   (define-key rmail-summary-mode-map "/"      'rmail-summary-end-of-message)
    (define-key rmail-summary-mode-map "<"      'rmail-summary-first-message)
    (define-key rmail-summary-mode-map ">"      'rmail-summary-last-message)
    (define-key rmail-summary-mode-map " "      'rmail-summary-scroll-msg-up)
***************
*** 1185,1190 ****
--- 1186,1201 ----
  (defun rmail-summary-beginning-of-message ()
    "Show current message from the beginning."
    (interactive)
+   (rmail-summary-show-message 'BEG))
+
+ (defun rmail-summary-end-of-message ()
+   "Show bottom of current message."
+   (interactive)
+   (rmail-summary-show-message 'END))
+
+ (defun rmail-summary-show-message (where)
+   "Show current mail message.
+ Position it according to WHERE which can be BEG or END"
    (if (and (one-window-p) (not pop-up-frames))
        ;; If there is just one window, put the summary on the top.
        (let ((buffer rmail-view-buffer))
***************
*** 1196,1203 ****
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (with-no-warnings
!     (beginning-of-buffer))
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()
--- 1207,1220 ----
  	(or (eq buffer (window-buffer (next-window (frame-first-window))))
  	    (delete-other-windows)))
      (pop-to-buffer rmail-view-buffer))
!   (cond
!    ((eq where 'BEG)
! 	(goto-char (point-min))
! 	(search-forward "\n\n"))
!    ((eq where 'END)
! 	(goto-char (point-max))
! 	(recenter (1- (window-height))))
!    )
    (pop-to-buffer rmail-summary-buffer))

  (defun rmail-summary-bury ()



diff -c rmail.el.~1.406.~ rmail-new.el
*** rmail.el.~1.406.~	Mon Jul 11 19:05:42 2005
--- rmail-new.el	Sat Aug  6 13:41:01 2005
***************
*** 952,957 ****
--- 952,958 ----
    (define-key rmail-mode-map "w"      'rmail-output-body-to-file)
    (define-key rmail-mode-map "x"      'rmail-expunge)
    (define-key rmail-mode-map "."      'rmail-beginning-of-message)
+   (define-key rmail-mode-map "/"      'rmail-end-of-message)
    (define-key rmail-mode-map "<"      'rmail-first-message)
    (define-key rmail-mode-map ">"      'rmail-last-message)
    (define-key rmail-mode-map " "      'scroll-up)
***************
*** 1096,1102 ****
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message (same as \\[beginning-of-buffer]).
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
--- 1097,1104 ----
  All normal editing commands are turned off.
  Instead, these commands are available:

! \\[rmail-beginning-of-message]	Move point to front of this message.
! \\[rmail-end-of-message]	Move point to bottom of this message.
  \\[scroll-up]	Scroll to next screen of this message.
  \\[scroll-down]	Scroll to previous screen of this message.
  \\[rmail-next-undeleted-message]	Move to Next non-deleted message.
***************
*** 2604,2610 ****
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (rmail-show-message rmail-current-message))

  (defun rmail-unknown-mail-followup-to ()
    "Handle a \"Mail-Followup-To\" header field with an unknown mailing list.
--- 2606,2624 ----
  (defun rmail-beginning-of-message ()
    "Show current message starting from the beginning."
    (interactive)
!   (let ((rmail-show-message-hook
! 	 (list (function (lambda ()
! 			   (goto-char (point-min)))))))
!     (rmail-show-message rmail-current-message)))
!
! (defun rmail-end-of-message ()
!   "Show bottom of current message."
!   (interactive)
!   (let ((rmail-show-message-hook
! 	 (list (function (lambda ()
! 			   (goto-char (point-max))
! 			   (recenter (1- (window-height))))))))
!     (rmail-show-message rmail-current-message)))

  (defun rmail-unknown-mail-followup-to ()
    "Handle a \"Mail-Followup-To\" header field with an unknown mailing list.



--
 Ehud Karni           Tel: +972-3-7966-561  /"\
 Mivtach - Simon      Fax: +972-3-7966-667  \ /  ASCII Ribbon Campaign
 Insurance agencies   (USA) voice mail and   X   Against   HTML   Mail
 http://www.mvs.co.il  FAX:  1-815-5509341  / \
 GnuPG: 98EA398D <http://www.keyserver.net/>    Better Safe Than Sorry