silence whitespace-cleanup

silence whitespace-cleanup

[Katsumi Yamaoka]

Hi,

I request to silence the whitespace-cleanup function when the
texinfo-format-scan function is performed.  We have only the way
to use the texinfmt.el module to make Japanese info pages.
However, it is too loud to find important problems.  For
instance:

Formatting: The Gnus Newsreader ... 
/Work/gnus/texi/gnus clean
/Work/gnus/texi/gnus clean
/Work/gnus/texi/gnus clean
/Work/gnus/texi/gnus clean
/Work/gnus/texi/gnus clean
/Work/gnus/texi/gnus clean
/Work/gnus/texi/gnus clean
[...]

Here is a patch:

*** lisp/whitespace.el~	Tue May 13 22:38:43 2003
--- lisp/whitespace.el	Wed Jun 11 02:06:37 2003
***************
*** 517,523 ****
        (whitespace-buffer))))
  
  ;;;###autoload
! (defun whitespace-cleanup ()
    "Cleanup the five different kinds of whitespace problems.
  
  Use \\[describe-function] whitespace-describe to read a summary of the
--- 517,523 ----
        (whitespace-buffer))))
  
  ;;;###autoload
! (defun whitespace-cleanup (&optional quiet)
    "Cleanup the five different kinds of whitespace problems.
  
  Use \\[describe-function] whitespace-describe to read a summary of the
***************
*** 568,574 ****
  	(if whitespace-any
  	    (whitespace-cleanup)
  	  (progn
! 	    (message "%s clean" buffer-file-name)
  	    (whitespace-update-modeline)))
  	(setq tab-width whitespace-tabwith-saved))))
  
--- 568,575 ----
  	(if whitespace-any
  	    (whitespace-cleanup)
  	  (progn
! 	    (if (not quiet)
! 		(message "%s clean" buffer-file-name))
  	    (whitespace-update-modeline)))
  	(setq tab-width whitespace-tabwith-saved))))
  
*** lisp/textmodes/texinfmt.el~	Tue Feb 11 22:13:39 2003
--- lisp/textmodes/texinfmt.el	Wed Jun 11 02:06:37 2003
***************
*** 935,941 ****
           (error "Unterminated @%s" (car (car texinfo-stack)))))
  
    ;; Remove excess whitespace
!   (whitespace-cleanup))
  
  (defvar texinfo-copying-text ""
    "Text of the copyright notice and copying permissions.")
--- 935,941 ----
           (error "Unterminated @%s" (car (car texinfo-stack)))))
  
    ;; Remove excess whitespace
!   (whitespace-cleanup t))
  
  (defvar texinfo-copying-text ""
    "Text of the copyright notice and copying permissions.")

Re: silence whitespace-cleanup

[Rajesh Vaidheeswarran]

I think it is a good idea. However, I'd do it differently. I'd rather
use the customization scheme to deal with the user's preferences than
by hardcoding the preferences, since a lot of others find the messages to be
useful.

Anyway, more mundane things like my inability to login to savannah are
stopping me from making the change right away... I'll get to it as soon
as I am able to.

Thanks for the suggestion.

rv


In a previous message, Katsumi Yamaoka writes:

> Hi,
> 
> I request to silence the whitespace-cleanup function when the
> texinfo-format-scan function is performed.  We have only the way
> to use the texinfmt.el module to make Japanese info pages.
> However, it is too loud to find important problems.  For
> instance:
> 
> Formatting: The Gnus Newsreader ... 
> /Work/gnus/texi/gnus clean
> /Work/gnus/texi/gnus clean
> /Work/gnus/texi/gnus clean
> /Work/gnus/texi/gnus clean
> /Work/gnus/texi/gnus clean
> /Work/gnus/texi/gnus clean
> /Work/gnus/texi/gnus clean
> [...]
> 
> Here is a patch:
> 
> *** lisp/whitespace.el~	Tue May 13 22:38:43 2003
> --- lisp/whitespace.el	Wed Jun 11 02:06:37 2003
> ***************
> *** 517,523 ****
>         (whitespace-buffer))))
>   
>   ;;;###autoload
> ! (defun whitespace-cleanup ()
>     "Cleanup the five different kinds of whitespace problems.
>   
>   Use \\[describe-function] whitespace-describe to read a summary of the
> --- 517,523 ----
>         (whitespace-buffer))))
>   
>   ;;;###autoload
> ! (defun whitespace-cleanup (&optional quiet)
>     "Cleanup the five different kinds of whitespace problems.
>   
>   Use \\[describe-function] whitespace-describe to read a summary of the
> ***************
> *** 568,574 ****
>   	(if whitespace-any
>   	    (whitespace-cleanup)
>   	  (progn
> ! 	    (message "%s clean" buffer-file-name)
>   	    (whitespace-update-modeline)))
>   	(setq tab-width whitespace-tabwith-saved))))
>   
> --- 568,575 ----
>   	(if whitespace-any
>   	    (whitespace-cleanup)
>   	  (progn
> ! 	    (if (not quiet)
> ! 		(message "%s clean" buffer-file-name))
>   	    (whitespace-update-modeline)))
>   	(setq tab-width whitespace-tabwith-saved))))
>   
> *** lisp/textmodes/texinfmt.el~	Tue Feb 11 22:13:39 2003
> --- lisp/textmodes/texinfmt.el	Wed Jun 11 02:06:37 2003
> ***************
> *** 935,941 ****
>            (error "Unterminated @%s" (car (car texinfo-stack)))))
>   
>     ;; Remove excess whitespace
> !   (whitespace-cleanup))
>   
>   (defvar texinfo-copying-text ""
>     "Text of the copyright notice and copying permissions.")
> --- 935,941 ----
>            (error "Unterminated @%s" (car (car texinfo-stack)))))
>   
>     ;; Remove excess whitespace
> !   (whitespace-cleanup t))
>   
>   (defvar texinfo-copying-text ""
>     "Text of the copyright notice and copying permissions.")
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel
> 

Re: silence whitespace-cleanup

[Miles Bader]

Rajesh Vaidheeswarran <rv@gnu.org> writes:
> I think it is a good idea. However, I'd do it differently. I'd rather
> use the customization scheme to deal with the user's preferences than
> by hardcoding the preferences, since a lot of others find the messages to be
> useful.

I think if any customization is required in this case, it's a part of
texinfo.el, not the whitespace stuff.  IOW, the argument should be
added, and texinfo.el can decide whether to make it customizable or not.

-Miles
-- 
97% of everything is grunge