From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Miles' patch still fixes xfaces.c Date: Tue, 27 May 2003 18:40:14 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200305262027.h4QKRtlO001787@rum.cs.yale.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1054075595 2852 80.91.224.249 (27 May 2003 22:46:35 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 27 May 2003 22:46:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed May 28 00:46:29 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19KnDB-0000jQ-00 for ; Wed, 28 May 2003 00:46:29 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19KnR5-0006dt-00 for ; Wed, 28 May 2003 01:00:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19KnEz-0001Gi-19 for emacs-devel@quimby.gnus.org; Tue, 27 May 2003 18:48:21 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19Kn8W-0007yQ-H4 for emacs-devel@gnu.org; Tue, 27 May 2003 18:41:40 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19Kn89-0007tz-RS for emacs-devel@gnu.org; Tue, 27 May 2003 18:41:18 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19Kn78-0007pL-OC for emacs-devel@gnu.org; Tue, 27 May 2003 18:40:14 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.20) id 19Kn78-0004iY-6a; Tue, 27 May 2003 18:40:14 -0400 Original-To: bob@rattlesnake.com In-reply-to: (bob@rattlesnake.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:14345 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14345 The recent change to xfaces.c has not fixed the problem that no one can permanently change :weight bold to :weight normal in the variable `mode-line-buffer-identification', which is buffer-local and in other places. I don't remember the issue. What does it mean to "permanently change" this? And why can't you do it? What happens if you try? Fortunately, Miles Bader posted a semi-fix on 18 Dec 2002. This was a `semi-fix' because his code sometimes led to a race condition and a crash in Emacs. But not very often. Mile's patch is diff -u -r1.266 xfaces.c --- src/xfaces.c 17 Nov 2002 23:51:19 -0000 1.266 +++ src/xfaces.c 18 Dec 2002 05:26:34 -0000 What is the change? (I gather the change was not installed.) Can Miles explain what caused the problem? Maybe we can find a better fix based on that info.