unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: editfns.c (Fformat): fix for segfault
Date: Sun, 04 May 2003 09:04:27 -0400	[thread overview]
Message-ID: <E19CJAJ-00014h-00@fencepost.gnu.org> (raw)
In-Reply-To: <85n0i4yvbs.fsf@pi.meyering.net> (message from Jim Meyering on Sat, 03 May 2003 16:10:47 +0200)

Does this solve the problem?

*** print.c.~1.185.~	Fri Mar 14 16:00:39 2003
--- print.c	Sat May  3 18:09:00 2003
***************
*** 759,772 ****
  {
    PRINTDECLARE;
    Lisp_Object printcharfun;
!   struct gcpro gcpro1, gcpro2;
!   Lisp_Object tem;
  
    /* Save and restore this--we are altering a buffer
       but we don't want to deactivate the mark just for that.
       No need for specbind, since errors deactivate the mark.  */
!   tem = Vdeactivate_mark;
!   GCPRO2 (object, tem);
  
    printcharfun = Vprin1_to_string_buffer;
    PRINTPREPARE;
--- 759,776 ----
  {
    PRINTDECLARE;
    Lisp_Object printcharfun;
!   /* struct gcpro gcpro1, gcpro2; */
!   Lisp_Object save_deactivate_mark;
!   int count = specpdl_ptr - specpdl;
! 
!   specbind (Qinhibit_modification_hooks, Qt);
  
    /* Save and restore this--we are altering a buffer
       but we don't want to deactivate the mark just for that.
       No need for specbind, since errors deactivate the mark.  */
!   save_deactivate_mark = Vdeactivate_mark;
!   /* GCPRO2 (object, save_deactivate_mark); */
!   abort_on_gc++;
  
    printcharfun = Vprin1_to_string_buffer;
    PRINTPREPARE;
***************
*** 781,790 ****
    Ferase_buffer ();
    set_buffer_internal (old);
  
!   Vdeactivate_mark = tem;
!   UNGCPRO;
  
!   return object;
  }
  
  DEFUN ("princ", Fprinc, Sprinc, 1, 2, 0,
--- 785,795 ----
    Ferase_buffer ();
    set_buffer_internal (old);
  
!   Vdeactivate_mark = save_deactivate_mark;
!   /* UNGCPRO; */
  
!   abort_on_gc--;
!   return unbind_to (count, object);
  }
  
  DEFUN ("princ", Fprinc, Sprinc, 1, 2, 0,

  reply	other threads:[~2003-05-04 13:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <851xzo9f2l.fsf@pi.meyering.net>
2003-04-28  2:36 ` editfns.c (Fformat): fix for segfault Kenichi Handa
2003-04-28 23:38 ` Richard Stallman
2003-04-29  2:50   ` Kenichi Handa
2003-04-29 19:28     ` Richard Stallman
2003-05-03 14:10   ` Jim Meyering
2003-05-04 13:04     ` Richard Stallman [this message]
2003-05-05  8:47       ` Jim Meyering
2003-05-05 19:10         ` Richard Stallman
2003-05-07  9:27           ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E19CJAJ-00014h-00@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).