From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: 4 minor suggestions for files.el Date: Sat, 19 Apr 2003 09:35:43 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200304142022.h3EKMHRu026814@rum.cs.yale.edu> <200304172139.h3HLdBvK009948@rum.cs.yale.edu> <1050672259.633.14.camel@localhost> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1050759425 7403 80.91.224.249 (19 Apr 2003 13:37:05 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 19 Apr 2003 13:37:05 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Apr 19 15:37:02 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 196sWb-0001uy-00 for ; Sat, 19 Apr 2003 15:37:01 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 196saQ-0003CK-00 for ; Sat, 19 Apr 2003 15:40:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 196sWM-0006Su-08 for emacs-devel@quimby.gnus.org; Sat, 19 Apr 2003 09:36:46 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 196sVv-000642-00 for emacs-devel@gnu.org; Sat, 19 Apr 2003 09:36:19 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 196sVt-00063Q-00 for emacs-devel@gnu.org; Sat, 19 Apr 2003 09:36:18 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 196sVL-0005vP-00 for emacs-devel@gnu.org; Sat, 19 Apr 2003 09:35:43 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 196sVL-0004qa-00; Sat, 19 Apr 2003 09:35:43 -0400 Original-To: Andre Spiegel In-reply-to: <1050672259.633.14.camel@localhost> (message from Andre Spiegel on 18 Apr 2003 15:24:20 +0200) Original-cc: monnier+gnu/emacs@rum.cs.yale.edu X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:13297 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:13297 VC does a revert-buffer after each version control operation, so that changes in version headers are picked up. If I understand correctly, the revert-buffer would be undoable. I think that is what he is proposing. I think that is a misguided feature. It is not right to undo the revert-buffer unless you can undo the whole VC operation with it. But that, if we can implement it, must be a VC operation; M-x undo should not be able to do it. I think that the correct way for check-in and update to interact with M-x undo is to transpose the old undo list somehow to the buffer as it has been updated. If I edit the buffer and then do an RCS check-in, and the check-in updates an RCS header in the file, and then I undo, this should not undo the change in the RCS header. Rather, it should undo the change that I made manually before the check-in. Likewise, if I edit the buffer and then do a CVS update, I should then be able to undo the edit I made, but not the changes made by the CVS update. Implementing this is nontrivial, but not impossible. The revert-buffer should never be undone without (say