unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: monnier+gnu/emacs@rum.cs.yale.edu
Subject: Re: 4 minor suggestions for files.el
Date: Fri, 18 Apr 2003 07:28:59 -0400	[thread overview]
Message-ID: <E196U39-0006a4-00@fencepost.gnu.org> (raw)
In-Reply-To: <200304172139.h3HLdBvK009948@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu)

    Huh?  It works just dandy here.  The undo-log is correct (and has
    the necessary entries corresponding to the insert-file operation).
    The only real issue is not correctness but performance: the undo-log
    might contain a very large string (if the insert-file operation had to
    modify a large part of the buffer).

I think I understand now--it treats the insert-file operation as an
ordinary undoable buffer change.

Spiegel, is that really the right thing to do in VC?

I also worry about the large strings.  Maybe there should be a file
size threshold on this change.

    I was wondering if it would be worth it to try and make insert-file
    even more clever: pass the `before' and `after' to diff and then apply
    the diff by hand.  This will preserve even more of the markers
    (and would make the undo-log smaller and more useful, in the case
    that revert-buffer doesn't flush it).

That is a very interesting idea.  Perhaps diff could have an output
format designed to give the best possible results with Emacs, and
for the highest efficiency.

  reply	other threads:[~2003-04-18 11:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-14 20:22 4 minor suggestions for files.el Stefan Monnier
2003-04-15 19:14 ` Kai Großjohann
2003-04-15 20:16 ` Kevin Rodgers
2003-04-16  4:40 ` Richard Stallman
2003-04-17 21:39   ` Stefan Monnier
2003-04-18 11:28     ` Richard Stallman [this message]
2003-04-18 13:24       ` Andre Spiegel
2003-04-18 14:23         ` Stefan Monnier
2003-04-18 14:36           ` Andre Spiegel
2003-04-18 14:40             ` Stefan Monnier
2003-04-19 19:11             ` Stefan Monnier
2003-04-22  0:45               ` Richard Stallman
2003-04-19 13:35         ` Richard Stallman
2003-04-29 21:07           ` Stefan Monnier
2003-05-05 14:32             ` Richard Stallman
2003-05-05 14:52               ` Andre Spiegel
2003-05-06 10:14                 ` Richard Stallman
2003-05-06 10:56                   ` Andre Spiegel
2003-05-07 11:51                     ` Richard Stallman
2003-05-07 12:31                       ` Andre Spiegel
2003-05-07 14:26                         ` Stefan Monnier
2003-05-09 11:20                         ` Richard Stallman
2003-05-06 13:00                   ` Stefan Monnier
2003-05-07 11:50                     ` Richard Stallman
2003-05-05 14:57               ` Stefan Monnier
2003-05-06 10:14                 ` Richard Stallman
2003-05-06 12:54                   ` Stefan Monnier
2003-05-07 11:50                     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E196U39-0006a4-00@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=monnier+gnu/emacs@rum.cs.yale.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).