From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: 4 minor suggestions for files.el Date: Wed, 16 Apr 2003 00:40:03 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200304142022.h3EKMHRu026814@rum.cs.yale.edu> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1050468635 27326 80.91.224.249 (16 Apr 2003 04:50:35 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 16 Apr 2003 04:50:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Apr 16 06:50:30 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 195esQ-00076R-00 for ; Wed, 16 Apr 2003 06:50:30 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 195eub-00017m-00 for ; Wed, 16 Apr 2003 06:52:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 195eoQ-0001ns-0C for emacs-devel@quimby.gnus.org; Wed, 16 Apr 2003 00:46:22 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 195emO-0001LN-00 for emacs-devel@gnu.org; Wed, 16 Apr 2003 00:44:16 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 195eiJ-0008Ve-00 for emacs-devel@gnu.org; Wed, 16 Apr 2003 00:40:34 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 195eiJ-0008VY-00 for emacs-devel@gnu.org; Wed, 16 Apr 2003 00:40:03 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 195eiJ-0008Ug-00; Wed, 16 Apr 2003 00:40:03 -0400 Original-To: "Stefan Monnier" In-reply-to: <200304142022.h3EKMHRu026814@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:13254 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:13254 Ideas 1, 2 and 3 are good ideas--please install them. However, I think that the name with-errors-caught is unnatural; please call it report-errors. Please don't change the argument to revert-buffer. It is intentional that M-x revert-buffer RET asks for confirmation. Idea 5 would be nice in principle, but it cannot possibly work right. There is no way to connect the locations in the undo list with the new buffer contents correctly. It would be an arbitrary decision, and the results of undoing those changes would be nonsensical. The only case in which this would really work right is when the buffer text is unchanged. That case may occur often in using VC. Perhaps you can make insert-file-contents detect it. insert-file-contents already tries to notice when text at the start of the buffer and/or text at the end of the buffer are unchanged. It could preserve the undo list when the stuff to undo is within the unchanged areas of the text at the beginning or the end.