From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: building directory Date: Sat, 05 Apr 2003 03:12:17 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20030404.171320.107253085.jet@gyve.org> <20030404.192718.48820567.jet@gyve.org> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1049540926 5379 80.91.224.249 (5 Apr 2003 11:08:46 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 5 Apr 2003 11:08:46 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sat Apr 05 13:08:45 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 191lXR-0001Od-00 for ; Sat, 05 Apr 2003 13:08:45 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 191lZw-0004bi-00 for ; Sat, 05 Apr 2003 13:11:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 191lXJ-0004kP-03 for emacs-devel@quimby.gnus.org; Sat, 05 Apr 2003 06:08:38 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 191lWn-0004cj-00 for emacs-devel@gnu.org; Sat, 05 Apr 2003 06:08:05 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 191lWk-0004bF-00 for emacs-devel@gnu.org; Sat, 05 Apr 2003 06:08:03 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.10.13) id 191lWk-0004ZP-00 for emacs-devel@gnu.org; Sat, 05 Apr 2003 06:08:02 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 191imf-0005T8-00; Sat, 05 Apr 2003 03:12:17 -0500 Original-To: Masatake YAMATO In-reply-to: <20030404.192718.48820567.jet@gyve.org> (message from Masatake YAMATO on Fri, 04 Apr 2003 19:27:18 +0900 (JST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12911 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12911 That is a good hack. As someone pointed out, it needs to cope with the situation that the sources are not present in the specified directory. The suggestion that you should search through the file rather than just go to the recorded line number is important. A few other little changes are called for. { PVEC_SUBR | (sizeof (struct Lisp_Subr) / sizeof (EMACS_INT)), \ - fnname, minargs, maxargs, lname, prompt, 0}; \ + fnname, minargs, maxargs, lname, prompt, 0, __FILE__, (short)__LINE__}; \ +DEFUN ("source-line", Fsource_line, Ssource_line, 1, 1, 0, Please call it `function-source-line'. Likewise for `function-source-file'. + return make_number((EMACS_INT)XSUBR(fun)->src_line); Please write a space before the first openparen. + "Path specifying the place where emacs C source files are. In the GNU conventions, we don't use the term "path" this way. Please say "Directory for visiting the Emacs C source files."