unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: building directory
Date: Sat, 05 Apr 2003 03:12:17 -0500	[thread overview]
Message-ID: <E191imf-0005T8-00@fencepost.gnu.org> (raw)
In-Reply-To: <20030404.192718.48820567.jet@gyve.org> (message from Masatake YAMATO on Fri, 04 Apr 2003 19:27:18 +0900 (JST))

That is a good hack.  As someone pointed out, it needs to cope with
the situation that the sources are not present in the specified
directory.

The suggestion that you should search through the file rather than
just go to the recorded line number is important.

A few other little changes are called for.

	 { PVEC_SUBR | (sizeof (struct Lisp_Subr) / sizeof (EMACS_INT)),	\
    -      fnname, minargs, maxargs, lname, prompt, 0};			\
    +      fnname, minargs, maxargs, lname, prompt, 0, __FILE__, (short)__LINE__}; \

    +DEFUN ("source-line", Fsource_line, Ssource_line, 1, 1, 0,

Please call it `function-source-line'.  Likewise for 
`function-source-file'.

    +    return make_number((EMACS_INT)XSUBR(fun)->src_line);

Please write a space before the first openparen.

    +  "Path specifying the place where emacs C source files are.

In the GNU conventions, we don't use the term "path" this way.
Please say "Directory for visiting the Emacs C source files."

  parent reply	other threads:[~2003-04-05  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-04  8:13 building directory Masatake YAMATO
2003-04-04 10:27 ` Masatake YAMATO
2003-04-04 12:10   ` Thien-Thi Nguyen
2003-04-04 12:21   ` Jan D.
2003-04-05  8:12   ` Richard Stallman [this message]
2003-04-04 14:51 ` Stefan Monnier
2003-04-05  8:12   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E191imf-0005T8-00@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).