From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Old redisplay bug in xdisp.c, question about change Date: Mon, 24 Mar 2003 14:27:41 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <200303232254.h2NMsobL004941@stubby.bodenonline.com> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1048534365 20047 80.91.224.249 (24 Mar 2003 19:32:45 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 24 Mar 2003 19:32:45 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Mar 24 20:32:43 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18xXg5-0005B7-00 for ; Mon, 24 Mar 2003 20:32:13 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18xXgh-0003cv-00 for ; Mon, 24 Mar 2003 20:32:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18xXf3-0006mC-07 for emacs-devel@quimby.gnus.org; Mon, 24 Mar 2003 14:31:09 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18xXdP-0006Yi-00 for emacs-devel@gnu.org; Mon, 24 Mar 2003 14:29:27 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18xXco-0005bR-00 for emacs-devel@gnu.org; Mon, 24 Mar 2003 14:28:52 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.10.13) id 18xXbm-0004jg-00 for emacs-devel@gnu.org; Mon, 24 Mar 2003 14:27:46 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 18xXbh-0005t6-00; Mon, 24 Mar 2003 14:27:41 -0500 Original-To: "Jan D." In-reply-to: <200303232254.h2NMsobL004941@stubby.bodenonline.com> (jan.h.d@swipnet.se) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12574 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12574 The comments indicate that the menu does not need to be updated, but apparently the tool bar is not updated either, because w->update_mode_line is not set to Qt. There seems to be no ill effects from reverting this change, but since I don't know why it was made in the first place, I can not be sure. Does anybody remember the reason for this change? I think I made this change just as an optimization. So it could be reverted safely. Another alternative is to execute, in that case, just the parts of the if-statement that are really needed in that case.