unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* BUG REPORT: "delsel.el"
@ 2003-02-28  0:07 Le Wang
  2003-03-02 20:33 ` Stefan Monnier
  2003-03-03 18:58 ` Richard Stallman
  0 siblings, 2 replies; 8+ messages in thread
From: Le Wang @ 2003-02-28  0:07 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hi,

I gave the `kill-line' symbol a property of 'kill for 'delete-selection.

After the region is killed, "delsel.el" attempts to deactivate the region, but 
of course in transient-mark-mode buffer modification deactivates the region 
automatically, leading to an error.  I've got a patch (see atached), I don't 
know if it's too simplistic, though.  I'm no lisp expert.

--
Le

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: delsel.el.diff --]
[-- Type: text/x-diff; name="delsel.el.diff", Size: 449 bytes --]

--- temp/delsel_old.el	2003-02-26 08:54:24.000000000 -0500
+++ c:/cygwin/usr/emacs-cvs/lisp/delsel.el	2003-02-26 08:55:08.000000000 -0500
@@ -75,8 +75,9 @@
   (if killp
       (kill-region (point) (mark))
     (delete-region (point) (mark)))
-  (setq mark-active nil)
-  (run-hooks 'deactivate-mark-hook)
+  (unless transient-mark-mode
+    (setq mark-active nil)
+    (run-hooks 'deactivate-mark-hook))
   t)
 
 (defun delete-selection-pre-hook ()

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2003-03-05 20:47 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-02-28  0:07 BUG REPORT: "delsel.el" Le Wang
2003-03-02 20:33 ` Stefan Monnier
2003-03-02 22:30   ` Le Wang
2003-03-04 18:22   ` Richard Stallman
2003-03-04 19:28     ` Le Wang
2003-03-03 18:58 ` Richard Stallman
2003-03-03 23:08   ` Le Wang
2003-03-05 20:47     ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).