From: Richard Stallman <rms@gnu.org>
Cc: monnier+gnu/emacs@rum.cs.yale.edu
Subject: Re: [andrew.maguire@ps.ge.com: RE: menu entries missing display of equivalent keyboard sequence]
Date: Wed, 29 Jan 2003 16:17:10 -0500 [thread overview]
Message-ID: <E18dza2-0006cS-00@fencepost.gnu.org> (raw)
In-Reply-To: <200301282250.h0SMo7M11772@rum.cs.yale.edu> (monnier+gnu/emacs@rum.cs.yale.edu)
- && !INTEGERP (Faref (this, make_number (0))))
+ && SYMBOLP (tem = Faref (this, make_number (0)))
+ && !NILP (Fmemq (XCAR (parse_modifiers (tem)), Vmenu_events)))
parse_modifiers is extremely expensive--it allocates space in caches.
Doing this for a lot of event types unnecessarily is a bad idea.
How many different non-integer prefix keys does parse_modifiers get
called for here? Maybe it is few enough that this is not a real
issue, but could you check?
If it is indeed few enough, please add a comment saying how many it was
and explaining this issue.
If it is many, then I think the code should operate at a lower level.
next prev parent reply other threads:[~2003-01-29 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E18QEHY-00040s-00@fencepost.gnu.org>
2003-01-16 0:13 ` [andrew.maguire@ps.ge.com: RE: menu entries missing display of equivalent keyboard sequence] Stefan Monnier
2003-01-18 0:45 ` Richard Stallman
2003-01-28 22:50 ` Stefan Monnier
2003-01-29 21:17 ` Richard Stallman [this message]
2003-01-30 15:21 ` Stefan Monnier
2003-01-31 19:20 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E18dza2-0006cS-00@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=monnier+gnu/emacs@rum.cs.yale.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).