From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: 21.3.50 for Cygwin: patch 5 Date: Fri, 10 Jan 2003 19:22:22 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <3E15B803.8080507@hekimian.com> <5xptrcjv3l.fsf@kfs2.cua.dk> <5xadifkudi.fsf@kfs2.cua.dk> <5x1y3pz3yd.fsf@kfs2.cua.dk> <5xlm1t49mh.fsf@kfs2.cua.dk> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1042244668 15469 80.91.224.249 (11 Jan 2003 00:24:28 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sat, 11 Jan 2003 00:24:28 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18X9Rp-00041B-00 for ; Sat, 11 Jan 2003 01:24:25 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18X9Y5-0005U1-00 for ; Sat, 11 Jan 2003 01:30:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18X9SQ-0004HJ-01 for emacs-devel@quimby.gnus.org; Fri, 10 Jan 2003 19:25:02 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18X9RF-0003E9-00 for emacs-devel@gnu.org; Fri, 10 Jan 2003 19:23:49 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18X9R1-0002xI-00 for emacs-devel@gnu.org; Fri, 10 Jan 2003 19:23:35 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18X9Pr-0001tI-00 for emacs-devel@gnu.org; Fri, 10 Jan 2003 19:22:23 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 18X9Pq-0000HX-00; Fri, 10 Jan 2003 19:22:22 -0500 Original-To: storm@cua.dk In-reply-to: <5xlm1t49mh.fsf@kfs2.cua.dk> (storm@cua.dk) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10643 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10643 The Glibc files mktime.c, gmalloc.c, and strftime.c use it. mktime.c and strftime.c does declare it if it isn't defined already, but gmalloc.c doesn't. Whether to rename the symbol __P when copying these files from Glibc is a painful issue. To be strictly correct, we should rename it. But renaming it would make the files different, and we'd rather they be identical. On the third hand, that are probably already different (though that is a problem we would want to fix). I guess we may as well leave __P alone unless we can figure out a solution that is really right. I still think we need a "tips and tricks" section in e.g. INSTALL-CVS or admin/README (or a new file somewhere) to mention things a developer should be aware of when working on emacs source code, notably: - requirement for legal papers, - what is a "tiny change" (and how they sum up) - how to document changes (ChangeLog, NEWS, manual pages) - indentation style, use of P_ macro, which header files to use (e.g. when should a function be added to lisp.h) - how we support multiple platforms [when to duplicate code, which files contain platform specific code, etc...] It is a good idea, but I don't have time to do it. Would you like to write this? Note that many of these questions are answered in standards.texi and maintain.texi, and I think you may as well refer to them rather than duplicate them.