From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: window.c: suggested patch window_scroll_pixel_based Date: Mon, 30 Dec 2002 10:27:04 -0500 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <36895EE4-1AD1-11D7-8795-003065478022@crt.se> Reply-To: rms@gnu.org NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1041263212 14135 80.91.224.249 (30 Dec 2002 15:46:52 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 30 Dec 2002 15:46:52 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18T27t-0003fe-00 for ; Mon, 30 Dec 2002 16:46:49 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18T29W-0006Ny-00 for ; Mon, 30 Dec 2002 16:48:30 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18T28F-0001hQ-0C for emacs-devel@quimby.gnus.org; Mon, 30 Dec 2002 10:47:11 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18T27s-0001Tq-00 for emacs-devel@gnu.org; Mon, 30 Dec 2002 10:46:48 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18T27j-0001Fd-00 for emacs-devel@gnu.org; Mon, 30 Dec 2002 10:46:41 -0500 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18T1om-0004oT-00 for emacs-devel@gnu.org; Mon, 30 Dec 2002 10:27:04 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 18T1om-0008W3-00; Mon, 30 Dec 2002 10:27:04 -0500 Original-To: Martin Fredriksson In-reply-to: <36895EE4-1AD1-11D7-8795-003065478022@crt.se> (message from Martin Fredriksson on Sun, 29 Dec 2002 02:59:49 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10368 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10368 I suggest following patch to window.c (window_scroll_pixel_based), to make 'scroll-down' be able to reach the start of the buffer. This patch partly backs out of 1.433 (rms, 2002/12/23). I apologize if I have misunderstood the issue. I have verified the patch on OpenBSD/X11 and OSX/Carbon. This problem does not happen for me, and your change reintroduces code that seems to be entirely wrong as far as I can tell. Why do you think it is right to test `start' here? It appears to me that BEGV is correct.