From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: jpw@shootybangbang.com (John Paul Wallington)
Newsgroups: gmane.emacs.devel
Subject: `mouse-drag-mode-line-1' doesn't handle dragging header-line up
Date: Thu, 21 Nov 2002 11:01:07 +0000
Sender: emacs-devel-admin@gnu.org
Message-ID: <E18Ep51-00031L-00@bundalo.shootybangbang.com>
NNTP-Posting-Host: main.gmane.org
X-Trace: main.gmane.org 1037876094 2069 80.91.224.249 (21 Nov 2002 10:54:54 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Thu, 21 Nov 2002 10:54:54 +0000 (UTC)
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 18Eoyy-0000XD-00
	for <emacs-devel@main.gmane.org>; Thu, 21 Nov 2002 11:54:52 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 18Ep2b-0000AO-00
	for <emacs-devel@quimby.gnus.org>; Thu, 21 Nov 2002 11:58:37 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 18EoyN-0003L1-00; Thu, 21 Nov 2002 05:54:15 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10)
	id 18EoxD-0002Bj-00
	for emacs-devel@gnu.org; Thu, 21 Nov 2002 05:53:03 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10)
	id 18Eox8-00023x-00
	for emacs-devel@gnu.org; Thu, 21 Nov 2002 05:53:02 -0500
Original-Received: from host217-42-8-24.range217-42.btcentralplus.com ([217.42.8.24] helo=bundalo.shootybangbang.com)
	by monty-python.gnu.org with esmtp (Exim 4.10)
	id 18Eox8-0001ve-00
	for emacs-devel@gnu.org; Thu, 21 Nov 2002 05:52:58 -0500
Original-Received: from jpw by bundalo.shootybangbang.com with local (Exim 3.32 #1 (Debian))
	id 18Ep51-00031L-00
	for <emacs-devel@gnu.org>; Thu, 21 Nov 2002 11:01:07 +0000
Original-To: emacs-devel@gnu.org
X-Attribution: jpw
X-Face: R(_z-<e!Z,qjN8xeu/^:Szs}15R'D_9}g7Qlm0x+2sF<`w9o]-oT>rF:grdKO.*u`n);p.i
 $Eiz=h^CO5eDYv"4:K@#\HN09*Ykx}}B{kF/KH}%f_o^Wp<kb`,1KLtZp"^C{-{e~S=IP0_"8B6K+C
 kbKw='FSzftzu
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.11
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:9593
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:9593

Presently in HEAD, `mouse-drag-mode-line-1' doesn't handle dragging
the header-line up, only down.

We could partially revert to RC, like so:

--- /build-emacs/emacs/lisp/mouse.el.~1.241.~	Wed May 29 17:36:55 2002
+++ /build-emacs/emacs/lisp/mouse.el	Thu Nov 21 10:34:56 2002
@@ -438,8 +438,10 @@
 		       (select-window start-event-window))
 		   ;; no.  grow/shrink the selected window
 		   ;(message "growth = %d" growth)
-		   (mouse-drag-move-window-bottom start-event-window growth))
-
+		   (if mode-line-p
+		       (mouse-drag-move-window-bottom start-event-window growth)
+		     (enlarge-window growth)))
+		 
 		 ;; if this window's growth caused another
 		 ;; window to be deleted because it was too
 		 ;; short, rescind the change.


Or instead of using `enlarge-window' in the nil `mode-line-p' case we
could use `mouse-drag-move-window-bottom' but move the window above,
like so:

(mouse-drag-move-window-bottom 
 (mouse-drag-window-above start-event-window) (- growth))


Or maybe there is a better fix.  WDYT?

-- 
John Paul Wallington