unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: monnier+gnu/emacs@rum.cs.yale.edu, quarl@hkn.eecs.berkeley.edu,
	emacs-devel@gnu.org
Subject: Re: [cvs] bug when using pc-selection-mode/transient-mark-mode
Date: Mon, 23 Sep 2002 23:24:33 -0400	[thread overview]
Message-ID: <E17tgJN-0006Si-00@fencepost.gnu.org> (raw)
In-Reply-To: <20020923011842.GA29226@gnu.org> (message from Miles Bader on Sun, 22 Sep 2002 21:18:42 -0400)

      (1) `mark-active' gets set to a (global) integer counter value instead of t.

      (2) In the current place where `deactivate-mark' is checked, it just
	  handles the current buffer, but also increments the global counter.

      (3) `switch-to-buffer' checks to see if `mark-active' is less than the
	  global counter value, and if so, checks the local value of
	  `deactivate-mark' and perhaps sets mark-active to nil.

    IOW, it lazily does the deactivation based on the local value of
    deactivate-mark.

    Is this too expensive a thing to take place in switch-to-buffer?

It is not too expensive, I think, but the idea to make deactivate-mark
hold a list of buffers is far far simpler and seems better to me.

    Doesn't that require all the places where deactivate-mark is set to be
    changed (in a non-trivial way)?  Sounds very annoying for programmers...
    [and a maintainance headache]

The places that just bind it to nil to ignore modifications don't need
to be changed.  The places that set it to nil don't need to be
changed.  The other references are very few.  In the toplevel directory,
I found two files that set the variable but really ought to bind it
to nil instead; I found two places (delsel.el and simple.el) that set
it to t.  Nothing else.

  parent reply	other threads:[~2002-09-24  3:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-16  5:55 [cvs] bug when using pc-selection-mode/transient-mark-mode Karl Chen
2002-09-16 19:27 ` Richard Stallman
2002-09-18  0:07   ` Karl Chen
2002-09-18 17:26     ` Richard Stallman
2002-09-19  7:11       ` Karl Chen
2002-09-19  8:00       ` Karl Chen
2002-09-19  8:48       ` Karl Chen
2002-09-20  3:45         ` Richard Stallman
2002-09-21  2:38           ` Karl Chen
2002-09-21 19:39             ` Richard Stallman
2002-09-22 22:48             ` Stefan Monnier
2002-09-23  1:05               ` Karl Chen
2002-09-23  1:18               ` Miles Bader
2002-09-23  1:25                 ` Miles Bader
2002-09-23 18:31                 ` Stefan Monnier
2002-09-23 20:34                 ` Kim F. Storm
2002-09-24  3:24                 ` Richard Stallman [this message]
2002-09-23 16:00               ` Richard Stallman
2002-09-23 20:38                 ` Kim F. Storm
2002-09-19 19:52       ` Karl Chen
2002-09-20 18:42         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E17tgJN-0006Si-00@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier+gnu/emacs@rum.cs.yale.edu \
    --cc=quarl@hkn.eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).