From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: Customizing key bindings (was: Re: [CVS] f7, f8 bound..) Date: Mon, 09 Sep 2002 19:33:37 -0400 Sender: emacs-devel-admin@gnu.org Message-ID: References: <200208271621.g7RGLNm30516@rum.cs.yale.edu> <5xhehfe3aj.fsf@kfs2.cua.dk> <874rdfaytt.fsf@pot.cnuce.cnr.it> <5xvg5sh06u.fsf@kfs2.cua.dk> <20020830235528.GA13207@gnu.org> <87ofbji88u.fsf@emacswiki.org> <87sn0scb0b.fsf@emacswiki.org> <87bs7ama8g.fsf@emacswiki.org> Reply-To: rms@gnu.org NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1031614597 11413 127.0.0.1 (9 Sep 2002 23:36:37 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 9 Sep 2002 23:36:37 +0000 (UTC) Cc: alex@emacswiki.org, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17oY56-0002xx-00 for ; Tue, 10 Sep 2002 01:36:36 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17oYfG-0000XH-00 for ; Tue, 10 Sep 2002 02:13:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17oY5A-00044U-00; Mon, 09 Sep 2002 19:36:40 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17oY2F-00038H-00 for emacs-devel@gnu.org; Mon, 09 Sep 2002 19:33:39 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17oY2E-00037E-00 for emacs-devel@gnu.org; Mon, 09 Sep 2002 19:33:39 -0400 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17oY2D-000378-00 for emacs-devel@gnu.org; Mon, 09 Sep 2002 19:33:37 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.10) id 17oY2D-0005xc-00; Mon, 09 Sep 2002 19:33:37 -0400 Original-To: abraham@dina.kvl.dk In-reply-to: (message from Per Abrahamsen on Mon, 09 Sep 2002 09:57:46 +0200) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:7774 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:7774 > It would be better to generate a defvar plus whatever other stuff > you need. I prefer doing most of the work in functions rather than macros, because if we change defkeymap in Emacs version X+1, then packages compiled by the user in Emacs version X will call the new function, and thus continue to work. I had a lot of such problems with easymenu.el. defvar does a number of things, and eval-defun-1 handles it specially, so please do generate a defvar. It is ok to do the rest with a single function call.