From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: John Paul Wallington Newsgroups: gmane.emacs.devel Subject: `eshell-under-cygwin-p' etc. inappropriate? Date: Tue, 06 Aug 2002 10:24:03 +0100 Sender: emacs-devel-admin@gnu.org Message-ID: NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1028625513 17849 127.0.0.1 (6 Aug 2002 09:18:33 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 6 Aug 2002 09:18:33 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17c0U2-0004dk-00 for ; Tue, 06 Aug 2002 11:18:30 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17c0p5-00020Z-00 for ; Tue, 06 Aug 2002 11:40:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17c0Ub-0001J2-00; Tue, 06 Aug 2002 05:19:05 -0400 Original-Received: from cmailm3.svr.pol.co.uk ([195.92.193.19]) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17c0UN-0001H0-00; Tue, 06 Aug 2002 05:18:51 -0400 Original-Received: from modem-103.new-mexico.dialup.pol.co.uk ([62.137.82.103] helo=bundalo.shootybangbang.com) by cmailm3.svr.pol.co.uk with esmtp (Exim 3.35 #1) id 17c0UL-00080P-00; Tue, 06 Aug 2002 10:18:49 +0100 Original-Received: from jpw by bundalo.shootybangbang.com with local (Exim 3.32 #1 (Debian)) id 17c0ZO-0001Cg-00; Tue, 06 Aug 2002 10:24:03 +0100 Original-To: johnw@gnu.org Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6304 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6304 I was suprised to discover that the following change was applied to Emacs yesterday: 2002-04-09 John Paul Wallington * esh-util.el (eshell-under-cygwin-p): New function. * em-cmpl.el (eshell-cmpl-ignore-case): Use it. * em-dirs.el (eshell/cd): Ditto. * em-glob.el (eshell-glob-case-insensitive): Ditto. * em-hist.el (eshell-previous-matching-input-string-position): Ditto. * esh-ext.el (eshell-binary-suffixes): Ditto. This was a patch I suggested for the eshell XEmacs package. I'm not certain it is appropriate for XEmacs, but I don't think it should have been installed in Emacs. I thought it had been rejected, rightly. In Emacs, the eshell files are located in the lisp/eshell subdirectory so the ChangeLog entry is wrong (they suit the XEmacs package layout). Furthermore, `eshell-under-cygwin-p' is a misleading name: it should probably be `eshell-under-xemacs-cygwin-p' or similar. I don't understand why these changes were installed now, four months after they were suggested. -- John Paul Wallington