From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@fencepost.gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: TODO: insert-file should warn if the file is modified
Date: Fri, 19 Apr 2002 09:47:06 -0400
Sender: emacs-devel-admin@gnu.org
Message-ID: <E16yYjC-0007yl-00@fencepost.gnu.org>
References: <m3adrzalqa.fsf@Janik.cz>
Reply-To: Eli Zaretskii <eliz@is.elta.co.il>
NNTP-Posting-Host: localhost.gmane.org
X-Trace: main.gmane.org 1019224128 29491 127.0.0.1 (19 Apr 2002 13:48:48 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Fri, 19 Apr 2002 13:48:48 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-admin@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.33 #1 (Debian))
	id 16yYkp-0007fY-00
	for <emacs-devel@main.gmane.org>; Fri, 19 Apr 2002 15:48:47 +0200
Original-Received: from fencepost.gnu.org ([199.232.76.164])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 16yZ4D-0000Hz-00
	for <emacs-devel@quimby.gnus.org>; Fri, 19 Apr 2002 16:08:49 +0200
Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org)
	by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian))
	id 16yYkb-0008Dd-00; Fri, 19 Apr 2002 09:48:33 -0400
Original-Received: from eliz by fencepost.gnu.org with local (Exim 3.34 #1 (Debian))
	id 16yYjC-0007yl-00; Fri, 19 Apr 2002 09:47:06 -0400
Original-To: Pavel@Janik.cz
In-Reply-To: <m3adrzalqa.fsf@Janik.cz> (Pavel@Janik.cz)
Errors-To: emacs-devel-admin@gnu.org
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.0.9
Precedence: bulk
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel/>
Xref: main.gmane.org gmane.emacs.devel:2781
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:2781

> From: Pavel@Janik.cz (Pavel =?iso-8859-2?q?Jan=EDk?=)
> Date: Fri, 19 Apr 2002 14:58:37 +0200
> 
>    * If you do an insert-file and that file is currently modified in
>      another buffer but not written yet, print a warning.
> 
> I think that it is pretty simple:
> 
> (defun file-is-modified-somewhere (filename)
>   "Check if the file FILENAME is modified inside Emacs.
> 
> Return buffer visiting the file FILENAME marked as modified.
> Otherwise, return nil."
>   (let ((result))
>     (dolist (buffer (buffer-list) result)
>       (if (and (string= filename (buffer-file-name buffer))
> 	       (buffer-modified-p buffer))
> 	         (setq result buffer)))))

What about buffer that visit the same file under a different name
(e.g., symlinks on Posix systems)?  Don't we want to catch those as
well?

In other words, perhaps you should base the search on file's
attributes, not just the name?