unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dima Kogan <dima@secretsauce.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Embedded modifiers in the regex engine
Date: Thu, 25 Feb 2016 23:19:32 -0800	[thread overview]
Message-ID: <E0988832-6473-407E-8A1D-35F019761505@secretsauce.net> (raw)
In-Reply-To: <83oab4g407.fsf@gnu.org>

On February 25, 2016 8:15:52 AM PST, Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Dima Kogan <dima@secretsauce.net>
>> Date: Wed, 24 Feb 2016 17:32:01 -0800
>> 
>> I've been thinking of ways to make some fancier aspects of isearch
>and
>> hi-lock work better, specifically, the way we handle the different
>> modes: case-fold, char-fold, lax-whitespace, etc.
>> <snip>
>> 
>> The best solution I can think of to clean this up is also the most
>> intrusive: adding support for pcre-style embedded modifiers to
>> activate/deactivate the modes.
>> 
>> So for instance "\\(?i\\)asdf" would be interpreted as a case-folding
>> regex regardless of the value of case-fold-search.
>
>I hope you are not proposing this as a replacement for the M-s
>toggles, because if so, I'm very much opposed.

This proposal is concerned with the internals of the regex parser only, so not trying to break M-s toggles.


>> As an example, currently hi-lock generates a complicated-looking
>regex
>> to emulate char-folding and case-folding. If we supported the
>modifiers,
>> this change would simply be a prepend of "\\(?i\\)" or whatever other
>> modes we want. This is simple and expected to be bug-free on the
>hi-lock
>> level. Bugs such as hi-lock not supporting char-fold and case-fold at
>> the same time would not happen.
>
>They will also not happen once character-folding is implemented via
>translation tables, instead of regular expressions.  The current
>implementation will go away at some point (one hopes).

OK, that's good to hear, but char-fold isn't causing all the funkyness here.

I'm looking at importing the regex test suite in glibc to emacs. Would this be possible even if the copyright holders of those tests haven't assigned their work to the fsf? These are tests and not part of emacs on some level, so would that make it ok?




  reply	other threads:[~2016-02-26  7:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  1:32 Embedded modifiers in the regex engine Dima Kogan
2016-02-25  6:11 ` John Wiegley
2016-02-25 21:05   ` Stefan Monnier
2016-02-25 16:15 ` Eli Zaretskii
2016-02-26  7:19   ` Dima Kogan [this message]
2016-02-26  9:08     ` Eli Zaretskii
2016-02-28  1:50       ` Dima Kogan
2016-02-28 16:00         ` Eli Zaretskii
2016-02-29 13:30           ` Richard Stallman
2016-03-01  0:49             ` Aurélien Aptel
2016-03-01 16:55               ` Richard Stallman
2016-03-09  0:34                 ` Dima Kogan
2016-03-28  0:23                   ` Dima Kogan
2016-03-28 15:28                     ` Eli Zaretskii
2016-03-28 18:05                       ` Dima Kogan
2016-03-28 18:24                         ` Eli Zaretskii
2016-03-29 21:23                           ` Dima Kogan
2016-03-31 16:28                             ` Eli Zaretskii
2016-04-23  4:17                             ` Dima Kogan
2016-04-23  7:48                               ` Eli Zaretskii
2016-04-24  7:34                                 ` Dima Kogan
2016-03-28 16:09                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E0988832-6473-407E-8A1D-35F019761505@secretsauce.net \
    --to=dima@secretsauce.net \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).