From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.devel Subject: Re: Adding indent-bars to ELPA Date: Thu, 25 Jul 2024 08:44:43 -0400 Message-ID: References: <864j8e7gl5.fsf@gnu.org> <3769876B-384A-4882-8228-E6CA9DF9D22A@gmail.com> <86y15q5a4p.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34364"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 25 14:45:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWxqr-0008oy-F7 for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Jul 2024 14:45:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWxq7-0003jR-No; Thu, 25 Jul 2024 08:44:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWxq6-0003jI-OM for emacs-devel@gnu.org; Thu, 25 Jul 2024 08:44:58 -0400 Original-Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWxq5-0004Ww-3g; Thu, 25 Jul 2024 08:44:58 -0400 Original-Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-81f88c9664bso2920339f.1; Thu, 25 Jul 2024 05:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721911495; x=1722516295; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2Cd0UeJil+UV+ixn7DgKxHQkEYExRovinRvPLKB8T28=; b=ffZRuxtFH+VanVphUT8nmGYQpec2ZR9cckCp8tUXzs6qAJSo9P8YFWtRUTFLOWOJJP lvE3360yWiQw0DPgflikPeiCNRN+nQs5AiacsyhbFTONoRrQxp6WiiNRThmT/wabQQSw 40bOOSrZsbVVSmUOdi8hLmWuPIkNcxfO9tuZaL1trhPWC2QiWnKtAB+nJb4V0BJUMJjk v8hkZ6uq+q9LdXoyIqx3tYH7GX/q6NabpaEPl3O1pIziak0uD5blhwrbPeFiAhXdTmNe KtwjOIYvhjdWQsAO+8/sxfjW7c6eH9VDWTdJeQmm/D3/i+pxsm96wpo+gTFePkUBFxFY kPpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721911495; x=1722516295; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2Cd0UeJil+UV+ixn7DgKxHQkEYExRovinRvPLKB8T28=; b=Bvq3Lzxx9udAg/GwnAs7XWWe/NBPUaRnOsGYskRO3ujDlaoHnIAlp1vPMkqSLeLBX8 02KoaCm8psuCL+Ub1C8AGZAH9dRJtFDNKNBHwWVOHVzvnSY2fXzBpvwNa1S5S1SqpyGJ LhKISGnZ3pbGqW5IFw0oz+1+G816fTlovqF+GOuQemiDmpLlYrL3EdHzegE6/65Ez4cF sFgspEX9mLuB6opChP5YFM10HM/k3gKhLjOJB2G9Z65t6msXmNdqWuFOo8CUD1cR5UnD E0+GP4ciEBEzhqVprHH1nXUwizHa4v5e2aFf9RwT24pkMgeYJxZBSkqx9YqCqm9HosGi z2/w== X-Gm-Message-State: AOJu0YxpsMu7fcXg4NnmMke5JV15iB0WXcpKFeClxpw5x8xWTiqakIXQ eeTJnTkD1MFR77SkEgURxTwo/KmsskF9MIHtovNxxQicfUT5eHqWjagE/g== X-Google-Smtp-Source: AGHT+IFN9ebRHUwxzu2vUZJzr6iXOvqwV2NOTUUB38XrQnBQRmyMH+HYs9TnhKCC2fZDD2OS1DizEw== X-Received: by 2002:a05:6602:1403:b0:804:fd88:3b08 with SMTP id ca18e2360f4ac-81f7e43f08dmr250996239f.10.1721911494754; Thu, 25 Jul 2024 05:44:54 -0700 (PDT) Original-Received: from smtpclient.apple (cm-24-53-187-34.buckeyecom.net. [24.53.187.34]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4c29fbdb362sm288416173.105.2024.07.25.05.44.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2024 05:44:54 -0700 (PDT) In-Reply-To: <86y15q5a4p.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.600.62) Received-SPF: pass client-ip=2607:f8b0:4864:20::d36; envelope-from=jdtsmith@gmail.com; helo=mail-io1-xd36.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322083 Archived-At: > On Jul 25, 2024, at 1:11=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: JD Smith >> Date: Wed, 24 Jul 2024 15:32:21 -0400 >> Cc: emacs-devel >>=20 >>> It seems to work well, but has some problems with RTL text. To see >>> this, visit xdisp.c, turn on the mode, then go to around line 1900, >>> set bidi-paragraph-direction to 'right-to-left', and scroll up and >>> down several times: you will see broken bars, both with >>> indent-bars-prefer-character nil and non-nil. >>=20 >> Hmm, I can say it's definitely never been tested with RTL. Is that a = mode people typically use for column-oriented content like code or = config files? Do you mean broken bars in the top partially displayed = line? I don't see any artifacts in RTL other than this, but I can't = rule out build-dependent issues of course. > these problems indicate > some subtle issues with display stuff in the package, so I'd suggest > at least to understand why they happen, if not fix them -- it could > well be that this is just a tip of some larger iceberg. >=20 > As for where I see broken bars: yes, they are at the top,=20 I took a look at the broken bars at the top, which are the only display = artifact I see in while in RTL. The problem turns out to be unrelated = to indent-bars, but rather I believe has revealed an Emacs display bug = in RTL mode pertaining to replacing display. The behavior is that the = left-to-right order of display replacing text remains incorrectly = un-inverted on the 1st displayed line. This is I believe what led to = the broken (and left-right color swapped) bars you are seeing. I've filed a bug report with a reproducer (not including stipples).=