From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?B?VmluY2VudCBCZWxh72NoZQ==?= Newsgroups: gmane.emacs.devel Subject: RE: 5x5 again Date: Wed, 25 May 2011 08:13:51 +0200 Message-ID: References: <80lixwr8hn.fsf@gmail.com>, NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="_79e283b5-3c53-44f3-bf59-323af6450657_" X-Trace: dough.gmane.org 1306304047 1847 80.91.229.12 (25 May 2011 06:14:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 25 May 2011 06:14:07 +0000 (UTC) Cc: Jay Belanger , emacs-devel To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 25 08:14:03 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QP7M1-0007Fc-DN for ged-emacs-devel@m.gmane.org; Wed, 25 May 2011 08:14:01 +0200 Original-Received: from localhost ([::1]:44175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QP7M0-0003ca-ND for ged-emacs-devel@m.gmane.org; Wed, 25 May 2011 02:14:00 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:55230) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QP7Lu-0003cT-Vx for emacs-devel@gnu.org; Wed, 25 May 2011 02:13:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QP7Lt-0002oO-Tx for emacs-devel@gnu.org; Wed, 25 May 2011 02:13:54 -0400 Original-Received: from dub0-omc1-s9.dub0.hotmail.com ([157.55.0.208]:4979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QP7Lt-0002oA-PX for emacs-devel@gnu.org; Wed, 25 May 2011 02:13:53 -0400 Original-Received: from DUB102-W40 ([157.55.0.237]) by dub0-omc1-s9.dub0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 24 May 2011 23:13:51 -0700 X-Originating-IP: [92.135.118.85] Importance: Normal In-Reply-To: X-OriginalArrivalTime: 25 May 2011 06:13:51.0922 (UTC) FILETIME=[EB286920:01CC1AA2] X-detected-operating-system: by eggs.gnu.org: Windows 2000 SP4, XP SP1+ X-Received-From: 157.55.0.208 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139691 Archived-At: --_79e283b5-3c53-44f3-bf59-323af6450657_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Ooops... I noticed another thing: in the docstring of 5x5=2C there the keymap is lis= ted=2C but I omitted to add that line: Solve with Calc \\[5x5-solve-suggest] I can prepare one more patch & Changelog --- with well capitalized sentence= s --- if you like. If I do this=2C I would also add a function to browse th= rough the other solutions found by the solver --- only the one with least H= amming weight being shown. Vincent. > From: monnier@iro.umontreal.ca > To: vincent.b.1@hotmail.fr > CC: emacs-devel@gnu.org=3B jay.p.belanger@gmail.com > Subject: Re: 5x5 again > Date: Tue=2C 24 May 2011 15:23:59 -0300 >=20 > > Here follows the Changelog and the patch. Sorry for the extra > > disturbance. >=20 > Installed=2C with the following nitpicks: >=20 > > * play/5x5.el (5x5-new-game=2C 5x5-randomize): reset > > 5x5-solver-output to nil when a new grid is cast. >=20 > "reset" needs to be capitalized. >=20 > > (5x5-log-init=2C 5x5-log): use defsubst instead of defmacro to shunt >=20 > "use" needs to be capitalized. >=20 > > these debugging traces=2C as defmacro breaks the compiled code. Note >=20 > Two spaces after ".". >=20 > > these logging facilities were not cleaned out as the aritmetic > > solver is not yet complete --- it works only for grid size =3D 5. So > > they may be useful again to design a more generic solution. >=20 > I moved this into the code=2C where it belongs. >=20 >=20 > Stefan = --_79e283b5-3c53-44f3-bf59-323af6450657_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Ooops...

I noticed another thing: in the docstring of 5x5=2C there t= he keymap is listed=2C but I omitted to add that line:

Solve with Ca= lc =3B =3B =3B =3B =3B =3B =3B =3B =3B&= nbsp=3B \\[5x5-solve-suggest]

I can prepare one more patch &=3B C= hangelog --- with well capitalized sentences --- if you like. If I do this= =2C I would also add a function to browse through the other solutions found= by the solver --- only the one with least Hamming weight being shown.
<= br> =3B =3B Vincent.

>=3B From: monnier@iro.umontreal.ca>=3B To: vincent.b.1@hotmail.fr
>=3B CC: emacs-devel@gnu.org=3B ja= y.p.belanger@gmail.com
>=3B Subject: Re: 5x5 again
>=3B Date: Tue= =2C 24 May 2011 15:23:59 -0300
>=3B
>=3B >=3B Here follows the= Changelog and the patch. Sorry for the extra
>=3B >=3B disturbance.=
>=3B
>=3B Installed=2C with the following nitpicks:
>=3B <= br>>=3B >=3B * play/5x5.el (5x5-new-game=2C 5x5-randomize): reset
&= gt=3B >=3B 5x5-solver-output to nil when a new grid is cast.
>=3B <= br>>=3B "reset" needs to be capitalized.
>=3B
>=3B >=3B (5x= 5-log-init=2C 5x5-log): use defsubst instead of defmacro to shunt
>=3B=
>=3B "use" needs to be capitalized.
>=3B
>=3B >=3B the= se debugging traces=2C as defmacro breaks the compiled code. Note
>=3B=
>=3B Two spaces after ".".
>=3B
>=3B >=3B these loggin= g facilities were not cleaned out as the aritmetic
>=3B >=3B solver= is not yet complete --- it works only for grid size =3D 5. So
>=3B &g= t=3B they may be useful again to design a more generic solution.
>=3B=
>=3B I moved this into the code=2C where it belongs.
>=3B
&= gt=3B
>=3B Stefan
= --_79e283b5-3c53-44f3-bf59-323af6450657_--