Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Christopher Howard]

> Does this happen when you byte-compile the bookmark+ files? Or only
> when you use the .el files?

I believe I am just using the .el files, and not byte-compiling, at least not on purpose.

I'm not very knowledgeable at this point on what triggers byte-compiling, and how things are cached. So, conceivably I might be using byte-compiled code unintentionally. I was originally running bookmark+ from guix repository and then uninstalled that. And then I cloned it from the git mirror and loaded that, using load-path and require. Then finally I downloaded all the files from emacswiki into a directory and was using loadpath and require to load that.

There does not appear to be any settings in my init.el file pertaining to byte compiling or native compiling, so presumably I am using whatever the default settings are for Emacs 30.0.91.

-- 
Christopher Howard

RE: [External] : Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Drew Adams]

(Caveat: I don't have Emacs 30.)

I think it should be enough, to test this, to just
load file bookmark+-mac.el, then file bookmark+-key.el.
There are no dependencies on any other Bookmark+ files.

This is the beginning of bookmark+-key.el:

(eval-when-compile
 (or (condition-case nil
         (load-library "bookmark+-mac") ; Use load-library to ensure latest .elc.
       (error nil))
     (require 'bookmark+-mac))); Require, so can load separately if not on `load-path'.

(eval-when-compile (unless (require 'cl-lib nil t)
                     (require 'cl)
                     (defalias 'cl-case 'case)))

File bookmark+-mac.el defines macro `bmkp-menu-bar-make-toggle',
which is used in bookmark+-key.el.

Re: [External] : Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Christopher Howard]

Drew Adams <drew.adams@oracle.com> writes:

> (Caveat: I don't have Emacs 30.)
>
> I think it should be enough, to test this, to just
> load file bookmark+-mac.el, then file bookmark+-key.el.
> There are no dependencies on any other Bookmark+ files.
>

Hi, so, I restarted Emacs 30, went into my folder with the bookmark+ files, and ran

``` elisp
(load-file "bookmark+-mac.el")
```

this returned t. Then I ran

``` elisp
(load-file "bookmark+-mac.el")
```

and this threw the error

> (error "Key sequence r K starts with non-prefix key r")

I am currently running emacs-30 branch commit d5723fc4f03, built two days ago.

However, I tried that again using "emacs -Q" and the error does not appear. So maybe an issue relating to my site config file, or the environment it is dragging in.

-- 
Christopher Howard

RE: [External] : Re: master 29bf0a8b31b 1/2: ; * etc/NEWS: Fix typos.

[Drew Adams]

> > (Caveat: I don't have Emacs 30.)
> >
> > I think it should be enough, to test this, to just
> > load file bookmark+-mac.el, then file bookmark+-key.el.
> > There are no dependencies on any other Bookmark+ files.
> >
> 
> Hi, so, I restarted Emacs 30, went into my folder with the bookmark+
> files, and ran
> 
> (load-file "bookmark+-mac.el")
> 
> this returned t. Then I ran
> 
> (load-file "bookmark+-mac.el")
                        ^^^

Did you mean (load-file "bookmark+-key.el")?

> and this threw the error
> 
> > (error "Key sequence r K starts with non-prefix key r")
> 
> I am currently running emacs-30 branch commit d5723fc4f03, built two
> days ago.
> 
> However, I tried that again using "emacs -Q" and the error does not
> appear. So maybe an issue relating to my site config file, or the
> environment it is dragging in.

Sounds like something like that.

Bookmark+ key sequence error

[Christopher Howard]

Drew Adams <drew.adams@oracle.com> writes:

>> (load-file "bookmark+-mac.el")
>                         ^^^
>
> Did you mean (load-file "bookmark+-key.el")?
>
>> and this threw the error
>> 
>> > (error "Key sequence r K starts with non-prefix key r")
>> 

Drew (and others): after extension init file troubleshooting, I determined that I can prevent or allow the error by removing or adding this line in my init.el:

``` elisp
(keymap-global-set "C-x r" 'org-roam-node-find)
```

Is it obvious I am doing something wrong in how I am using keymap-global-set, or have I unearthed some kind of Emacs bug?

Again, the line in bookmark+-key.el, which throws the error, is:

```
(define-key ctl-x-map "rK" 'bmkp-set-desktop-bookmark)        ; `C-x r K' (also `C-x x K', `C-x x c K')
```

-- 
Christopher Howard

RE: [External] : Bookmark+ key sequence error

[Drew Adams]

> >> > (error "Key sequence r K starts with non-prefix key r")
> >>
> 
> Drew (and others): after extension init file troubleshooting, I
> determined that I can prevent or allow the error by removing or adding
> this line in my init.el:
> 
> (keymap-global-set "C-x r" 'org-roam-node-find)
> 
> Is it obvious I am doing something wrong in how I am using keymap-
> global-set, or have I unearthed some kind of Emacs bug?
> 
> Again, the line in bookmark+-key.el, which throws the error, is:
> 
> (define-key ctl-x-map "rK" 'bmkp-set-desktop-bookmark)        ; `C-x r
> K' (also `C-x x K', `C-x x c K')

Thanks for tracking down the cause.

If you bind `C-x r' to a command then it's no
longer available as a prefix key.  Hence the
error in trying to use that key in the key
binding that raises the error.

The same key sequence, in this case `C-x r',
can't serve both to invoke a command and to
initiate a longer key sequence (as a prefix
key).