unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
Subject: RE: Minor problem with calc-quit
Date: Tue, 30 May 2006 16:19:18 -0700	[thread overview]
Message-ID: <DNEMKBNJBGPAOPIJOOICKENEDGAA.drew.adams@oracle.com> (raw)
In-Reply-To: <20060531001005.07A6.SLAWOMIR.NOWACZYK.847@student.lu.se>

    Turns out I had Drew Adams' "frame-cmds.el" in my load path, which
    contains its own version of delete-windows-on and which somehow was
    being loaded even for "emacs -Q".
    
    #> The function `delete-windows-on' returns nil when there is no *Calc
    #> Keypad* (i.e., the argument for `delete-windows-on' is nil; I tested
    #> that) and (presumably) deletes the buffer containing the key pad when
    #> it exists.
    
    Right... It turns out that version from frame-cmds.el doesn't handle
    the case of "buffer" argument being nil all that well... Drew, you
    might want to do something about that :)
    
Fixed in frame-cmds.el. Thanks for the report.

Sounds to me like calc is counting on an undocumented "feature" of `delete-windows-on', which might not be such a good idea.

Perhaps the doc string for `delete-windows-on' should say something about this behavior, to legitimize programs counting on it. It says, instead, that "BUFFER must be a buffer or the name of an existing buffer", which obviously excludes nil as a valid value. The doc string suggests that with any other value than those mentioned you'll get an error, or unpredictable results, or... Perhaps it should say explicitly that it returns nil if BUFFER is nil.

      reply	other threads:[~2006-05-30 23:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-30 11:32 Minor problem with calc-quit Slawomir Nowaczyk
2006-05-30 12:55 ` Robert J. Chassell
2006-05-30 22:51   ` Slawomir Nowaczyk
2006-05-30 23:19     ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DNEMKBNJBGPAOPIJOOICKENEDGAA.drew.adams@oracle.com \
    --to=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).