From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.mail.mh-e.devel,gmane.emacs.devel Subject: RE: mh-e/mh-acros.el advices `require' incorrectly Date: Fri, 13 Jan 2006 13:04:15 -0800 Message-ID: References: <87oe2gez38.fsf@olgas.newt.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1137188434 21934 80.91.229.2 (13 Jan 2006 21:40:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 13 Jan 2006 21:40:34 +0000 (UTC) Cc: Original-X-From: mh-e-devel-admin@lists.sourceforge.net Fri Jan 13 22:40:22 2006 Return-path: Envelope-to: gmmd-mh-e-devel@m.gmane.org Original-Received: from lists-outbound.sourceforge.net ([66.35.250.225]) by ciao.gmane.org with esmtp (Exim 4.43) id 1ExWeS-0001wB-OO for gmmd-mh-e-devel@m.gmane.org; Fri, 13 Jan 2006 22:40:05 +0100 Original-Received: from sc8-sf-list1-b.sourceforge.net (sc8-sf-list1-b.sourceforge.net [10.3.1.7]) by sc8-sf-spam2.sourceforge.net (Postfix) with ESMTP id E95F212DE3; Fri, 13 Jan 2006 13:40:03 -0800 (PST) Original-Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1ExW6H-0004t7-QF for mh-e-devel@lists.sourceforge.net; Fri, 13 Jan 2006 13:04:45 -0800 Original-Received: from agminet01.oracle.com ([141.146.126.228]) by mail.sourceforge.net with esmtps (TLSv1:DES-CBC3-SHA:168) (Exim 4.44) id 1ExW6H-0006GM-FJ for mh-e-devel@lists.sourceforge.net; Fri, 13 Jan 2006 13:04:45 -0800 Original-Received: from rgmsgw300.us.oracle.com (rgmsgw300.us.oracle.com [138.1.186.49]) by agminet01.oracle.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id k0DL4P0u006544; Fri, 13 Jan 2006 15:04:25 -0600 Original-Received: from rgmsgw300.us.oracle.com (localhost [127.0.0.1]) by rgmsgw300.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id k0DL4ODY029604; Fri, 13 Jan 2006 14:04:24 -0700 Original-Received: from dradamslap (dhcp-amer-rmdc-csvpn-gw6-141-144-115-191.vpn.oracle.com [141.144.115.191]) by rgmsgw300.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with SMTP id k0DL4N9S029596 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Fri, 13 Jan 2006 14:04:24 -0700 Original-To: X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: <87oe2gez38.fsf@olgas.newt.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1506 Importance: Normal X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Spam-Score: 0.0 (/) X-Spam-Report: Spam Filtering performed by sourceforge.net. See http://spamassassin.org/tag/ for more details. Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001 Original-Sender: mh-e-devel-admin@lists.sourceforge.net Errors-To: mh-e-devel-admin@lists.sourceforge.net X-BeenThere: mh-e-devel@lists.sourceforge.net X-Mailman-Version: 2.0.9-sf.net Precedence: bulk List-Unsubscribe: , List-Id: Forum for the MH-E developers List-Post: List-Help: List-Subscribe: , List-Archive: X-Original-Date: Fri, 13 Jan 2006 13:04:15 -0800 Xref: news.gmane.org gmane.mail.mh-e.devel:11267 gmane.emacs.devel:49023 Archived-At: > The origianl `require' returns FEATURE even if it is already > provided, but the adviced `require' returns nil in such a > case. So, once mh-acros.el is loaded, a code depending on > the return value of `require' stops working. > > How about this change? What do you (and others) think about this? Besides the fact that we shouldn't use defadvice in vanilla Emacs code, I don't think we should change the return value of `require' at all. It has acted this way for a very long time, and there is undoubtedly code that depends on this behavior (at least some external libraries). Besides, we certainly should not make such a change just before a release. ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click