From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: no doc for `group' in custom :type Date: Mon, 26 Nov 2007 10:16:21 -0800 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1196101026 28963 80.91.229.12 (26 Nov 2007 18:17:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 26 Nov 2007 18:17:06 +0000 (UTC) Cc: per.abrahamsen@gmail.com, emacs-devel@gnu.org To: Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 26 19:17:14 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IwiVo-0000YU-6P for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2007 19:16:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IwiVY-0000R2-So for ged-emacs-devel@m.gmane.org; Mon, 26 Nov 2007 13:16:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IwiVT-0000P4-QR for emacs-devel@gnu.org; Mon, 26 Nov 2007 13:16:31 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IwiVS-0000OC-Fh for emacs-devel@gnu.org; Mon, 26 Nov 2007 13:16:31 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IwiVS-0000O6-0a for emacs-devel@gnu.org; Mon, 26 Nov 2007 13:16:30 -0500 Original-Received: from agminet01.oracle.com ([141.146.126.228]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IwiVN-0008HH-JU; Mon, 26 Nov 2007 13:16:25 -0500 Original-Received: from rgmgw2.us.oracle.com (rgmgw2.us.oracle.com [138.1.186.111]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id lAQIGLx6016233; Mon, 26 Nov 2007 12:16:21 -0600 Original-Received: from rcsmt251.oracle.com (rcsmt251.oracle.com [148.87.90.196]) by rgmgw2.us.oracle.com (Switch-3.2.4/Switch-3.2.4) with ESMTP id lAQEOIHu025448; Mon, 26 Nov 2007 11:16:20 -0700 Original-Received: from dhcp-4op11-4op12-west-130-35-178-158.us.oracle.com by acsmt351.oracle.com with ESMTP id 3387292701196100979; Mon, 26 Nov 2007 10:16:19 -0800 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-Reply-To: Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3198 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84154 Archived-At: > The doc bug described below was apparently fixed by just > adding an explanation of the type `group' (in node Common > Keywords). > > I do not see that. Can you please SHOW the text you are referring > to rather than describing it? My bad. I thought you had added an explanation of `group' in node Common Keywords, but I was mistaken. > Anyway that is the wrong place to explain a type. > So I just wrote text to expain `group' in Composite Types. I can't find where such an explanation was added, so the bug seems to be still outstanding as it was originally reported: no explanation of type `group'. The only occurrence of `group' I see in node Composite Types (latest CVS texinfo) is this: @item :indent @var{columns} Indent this item by @var{columns} columns. The indentation is used for @samp{%n}, and automatically for group names, for checklists and radio buttons, and for editable lists. It affects the whole of the item except for the first line. That doesn't explain what the type `group' is. > However, the example that should have been changed to use > `list' instead of `group' still uses `group'. See type `alist' > in node Simple Types. > > Do you mean this? > > @smallexample > (defcustom list-alist '(("foo" 1) ("bar" 2) ("baz" 3)) > "Each element is a list of the form (KEY VALUE)." > :type '(alist :value-type (group integer))) > @end smallexample Yes. > I think it is ok to use `group' if that looks better. I guess you mean that a `group' type looks better than a `list' type in a Customize buffer. Maybe so. If you substitute `list' for `group' in that example, the only difference is that `List:' is added before `Integer: 1'. OK, that's looks a little better. However, it is less clear, especially in an example intended to explain use of the `alist' type with a list as the value component. `list' should be used here because the type is a list of one integer - the type spec should be written (list integer). And the mysterious sentence still follows the example: The @code{group} widget is used here instead of @code{list} only because the formatting is better suited for the purpose. It's not clear here what formatting is meant - the formatting in the Customize buffer. Per my reading of Per's mail, `group' is for widgets, rather than being intended as a customizaton type. He said: > The custom types, by nature, always represent sexps. > So only the sexp expressions should be used. That means `list', not `group' should be used, AFAICT. I don't understand why a discussion of Customize types would introduce `group' at all, if it is for widgets but not for Customize types. And if `group' is also intended for Customize types, then it needs to be documented. This example uses the type `group', but it was never introduced.