From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: Question on remapping keys Date: Fri, 20 Jan 2006 15:25:45 -0800 Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1137803819 17102 80.91.229.2 (21 Jan 2006 00:36:59 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 21 Jan 2006 00:36:59 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 21 01:36:59 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F06kS-0001br-He for ged-emacs-devel@m.gmane.org; Sat, 21 Jan 2006 01:36:57 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F06lq-00025q-Me for ged-emacs-devel@m.gmane.org; Fri, 20 Jan 2006 19:38:22 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F05gJ-00041Q-0g for emacs-devel@gnu.org; Fri, 20 Jan 2006 18:28:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F05gG-0003yC-LE for emacs-devel@gnu.org; Fri, 20 Jan 2006 18:28:33 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F05gD-0003ws-65 for emacs-devel@gnu.org; Fri, 20 Jan 2006 18:28:31 -0500 Original-Received: from [148.87.122.30] (helo=rgminet01.oracle.com) by monty-python.gnu.org with esmtp (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.34) id 1F05kU-0006m4-Pt for emacs-devel@gnu.org; Fri, 20 Jan 2006 18:32:55 -0500 Original-Received: from rgmsgw300.us.oracle.com (rgmsgw300.us.oracle.com [138.1.186.49]) by rgminet01.oracle.com (Switch-3.1.6/Switch-3.1.6) with ESMTP id k0KNPoSF010302 for ; Fri, 20 Jan 2006 16:25:50 -0700 Original-Received: from rgmsgw300.us.oracle.com (localhost [127.0.0.1]) by rgmsgw300.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with ESMTP id k0KNPnfw007456 for ; Fri, 20 Jan 2006 16:25:49 -0700 Original-Received: from dradamslap (dhcp-amer-rmdc-csvpn-gw5-141-144-107-196.vpn.oracle.com [141.144.107.196]) by rgmsgw300.us.oracle.com (Switch-3.1.7/Switch-3.1.7) with SMTP id k0KNPn99007448 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO) for ; Fri, 20 Jan 2006 16:25:49 -0700 Original-To: "Emacs-Devel" X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.6604 (9.0.2911.0) In-reply-to: Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1506 X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49341 Archived-At: I realize that I sent this question only yesterday. Today, I noticed that code identical to what I use (see `my-remap', below) is used in `arc-mode.el' and `emerge.el' (and `tramp-util.el' and `picture.el' do something similar), so it's apparently not a far-out request. Is this a bug? If not, how can I get remapping to substitute _all_ of a command's bindings? Thanks. P.S. Actually, `emerge.el' does _both_ `substitute-key-definition' and remapping for the same commands. Is this useful? (Perhaps it has to do with not using an OLDMAP arg with `substitute-key-definition'?) ---- I sent this to help-gnu-emacs, but I haven't yet found a solution to the problem. I wonder too if there might be a bug here. I have a minor mode that redefines some of the minibuffer keymaps (e.g. minibuffer-local-completion-map). I want turning on the mode to implement the new minibuffer bindings, and turning it off to restore the minibuffer bindings of vanilla Emacs. In some cases, I reuse key sequences that are bound in the global map, binding them to other commands in minibuffer maps. Those are the bindings that I have a question about. In Emacs 20, I simply do this: (substitute-key-definition from to minibuffer-local-completion-map global-map) For example, to bind `C-h' in the minibuffer to command `my-help': (substitute-key-definition 'help-command 'my-help minibuffer-local-completion-map global-map) I do the same for `self-insert-command', replacing it with `my-self-insert' for minibuffer maps. This is very fast in Emacs 20, but in Emacs 22 it is unbearably slow. It takes about 5 seconds for only 10 such key-definition substitutions! I think that the slowness might be due, in particular, to dealing with the case of `self-insert-command'. Someone (Kim?) suggested that I could use `define-key' with [remap...] instead of `substitute-key-definition'. I tried using the following when my minor mode is turned on: (defun my-remap (from to map) "Remap command FROM to command TO in keymap MAP." (if (boundp 'this-original-command) (define-key map `[remap ,from] to) ; Emacs 22 (substitute-key-definition from to map global-map))) ; Emacs 20 And similarly when it is turned off, using nil for TO, to remove the binding from MAP (a minibuffer map). The result of remapping is this for minibuffer-local-completion-map: (keymap ... (remap keymap (scroll-left . my-scroll-left) (scroll-right . my-scroll-right) (scroll-down . my-scroll-down) (scroll-up . my-scroll-up) (next-line . my-next-line) (previous-line . my-previous-line) (help-command . my-help) (self-insert-command . my-self-insert)) ...) This looks promising, but it seems to work only partially. For instance, (where-is-internal 'my-scroll-up (list minibuffer-local-completion-map)) returns ([remap scroll-up]), which looks good. `M-x' followed by `C-v' does invoke `my-scroll-up', but `M-x' followed by [next] (also bound to `scroll-up' in `global-map') does not invoke `my-scroll-up' - it invokes `next-history-element', just as in vanilla Emacs. IOW, apparently not all bindings of `scroll-up' got remapped. I don't know if this is a bug or by design. I'm looking for behavior similar to that of `substitute-key-definition': remap/substitute _all_ bindings. This is especially important since I apparently have no control over which single binding gets remapped - that is, only one binding of the command seems to be remapped, and I don't know how to pick which one. Similarly, (where-is-internal 'my-help (list minibuffer-local-completion-map)) returns ([remap help-command]). That suggests that `help-command' was remapped, but using `C-h' in the minibuffer does not invoke `my-help'. (Why?) If I use `substitute-key-definition', providing `global-map' as the OLDMAP arg, it works perfectly, but the performance is unacceptable in Emacs 22. There must be some way to do something equivalent using command remapping(?). Anyone have a suggestion on how to proceed? _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel