23.0.50; Holidays from year 2007 are displayed in a buffer named 2002

23.0.50; Holidays from year 2007 are displayed in a buffer named 2002

[Peter Dyballa]

Hello!

When I launch GNU Emacs as

	src/emacs -Q --debug-init &

and then execute calendar, it comes up. When I then choose year 2007  
from the Holidays menu the holidays buffer has "Holidays for 2002" in  
its mode line – and the holiday dates are recorded as coming from  
2002, which I can't check further, because my oldest calendar is from  
2005. And, of course, these holidays are mostly so strange that no  
German calendar mentions them.

Oh, why can't view-lossage prove that I've really chosen 2007 and not  
2002 from the menu?


In GNU Emacs 23.0.50.1 (powerpc-apple-darwin8.11.0, X toolkit, Xaw3d  
scroll bars)
  of 2007-11-24 on Latsche.local
Windowing system distributor `The XFree86 Project, Inc', version  
11.0.40400000
configured using `configure  '--without-gtk' '--without-sound' '-- 
without-pop' '--with-x-toolkit=lucid' '--with-xpm' '--with-jpeg' '-- 
with-tiff' '--with-gif' '--with-png' '--enable-locallisppath=/Library/ 
Application Support/Emacs/calendar22:/Library/Application Support/ 
Emacs/caml:/Library/Application Support/Emacs:/sw/share/emacs21/site- 
lisp/elib' 'CPPFLAGS=-no-cpp-precomp -I/usr/local/include -I/sw/ 
include' 'CXXFLAGS=-no-cpp-precomp -I/usr/local/include -I/sw/ 
include' 'CFLAGS=-pipe -bind_at_load -fPIC -mcpu=7450 -mtune=7450 - 
fast -mpim-altivec -ftree-vectorize -foptimize-register-move - 
freorder-blocks -freorder-blocks-and-partition -fthread-jumps - 
fpeephole -fno-crossjumping' 'LDFLAGS=-dead_strip -multiply_defined  
suppress -bind_at_load -L/sw/lib/ncurses -L/usr/local/lib -L/sw/lib - 
lresolv''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: de_DE.UTF-8
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: de_DE.UTF-8
   locale-coding-system: utf-8
   default-enable-multibyte-characters: t

Major mode: Calendar

Minor modes in effect:
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   unify-8859-on-encoding-mode: t
   utf-translate-cjk-mode: t
   auto-compression-mode: t
   line-number-mode: t

Recent input:
<down-mouse-1> <mouse-1> <escape> x c a l e n d a r
<return> <menu-bar> <Holidays> <For Year> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <menu-bar> <help-menu> <send-emacs-bug
-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Computing holidays...done


--
Mit friedvollen Grüßen

   Pete

There is no national science just as there is no national  
multiplication table; what is national is no longer science.
                                       -- Anton Checov

Re: 23.0.50; Holidays from year 2007 are displayed in a buffer named 2002

[Mark A. Hershberger]

Peter Dyballa <Peter_Dyballa@Freenet.DE> writes:

> When I then choose year 2007 from the Holidays menu the holidays
> buffer has "Holidays for 2002" in its mode line – and the holiday
> dates are recorded as coming from 2002, which I can't check further,
> because my oldest calendar is from 2005

I was able to reproduce this with the latest CVS snapshot.

I've applied the following patch to fix it:

*** cal-menu.el.~1.76.~	2007-11-21 23:17:17.000000000 -0500
--- cal-menu.el	2007-11-24 14:38:15.000000000 -0500
***************
*** 95,107 ****
      ,@(let ((l ()))
          ;; Show 11 years--5 before, 5 after year of middle month.
          (dotimes (i 11)
!           (push (vector "For Year"
!                         `(lambda ()
!                            (interactive)
!                            (holiday-list (+ displayed-year ,(- i 5))
!                                          (+ displayed-year ,(- i 5))))
!                         :suffix `(number-to-string (+ displayed-year ,(- i 5))))
!                 l))
          (nreverse l))
      "--"
      ["Unmark Calendar" calendar-unmark]
--- 95,105 ----
      ,@(let ((l ()))
          ;; Show 11 years--5 before, 5 after year of middle month.
          (dotimes (i 11)
! 	  (let ((y (+ 2007 -5 i)))
! 	    (push (vector (format "For Year %s" y)
! 			  (list (list 'lambda 'nil '(interactive)
! 				      (list 'list-holidays y y))))
!                 l)))
          (nreverse l))
      "--"
      ["Unmark Calendar" calendar-unmark]


-- 
http://hexmode.com/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2  B37A 735E F10A 2DFC BFF5

The most beautiful experience we can have is the mysterious.
    -- Albert Einstein, The World As I See it

Re: 23.0.50; Holidays from year 2007 are displayed in a buffer named 2002

[Glenn Morris]

Mark A. Hershberger wrote:

> I've applied the following patch to fix it:

You didn't make a ChangeLog entry. Hard-coding "2007" was obviously
wrong, and I think the problem may not actually be here, but rather in
easymenu, so I reverted this for now.

Re: 23.0.50; Holidays from year 2007 are displayed in a buffer named 2002

[Mark A. Hershberger]

Glenn Morris <rgm@gnu.org> writes:

> Mark A. Hershberger wrote:
>
>> I've applied the following patch to fix it:
>
> You didn't make a ChangeLog entry. Hard-coding "2007" was obviously
> wrong, and I think the problem may not actually be here, but rather in
> easymenu, so I reverted this for now.

Thank you!

-- 
http://hexmode.com/
GPG Fingerprint: 7E15 362D A32C DFAB E4D2  B37A 735E F10A 2DFC BFF5

The most beautiful experience we can have is the mysterious.
    -- Albert Einstein, The World As I See it