From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.devel Subject: RE: patch for next-error highlighting Date: Tue, 26 May 2009 12:47:50 -0700 Message-ID: References: <001d01c99543$ae7f1000$0200a8c0@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1243367267 30820 80.91.229.12 (26 May 2009 19:47:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 May 2009 19:47:47 +0000 (UTC) To: "'Emacs-Devel devel'" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 26 21:47:44 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M92ch-0002H2-Cb for ged-emacs-devel@m.gmane.org; Tue, 26 May 2009 21:47:43 +0200 Original-Received: from localhost ([127.0.0.1]:57689 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M92cg-0006gA-Ps for ged-emacs-devel@m.gmane.org; Tue, 26 May 2009 15:47:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M92cb-0006fS-Ju for emacs-devel@gnu.org; Tue, 26 May 2009 15:47:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M92cX-0006dM-CB for emacs-devel@gnu.org; Tue, 26 May 2009 15:47:37 -0400 Original-Received: from [199.232.76.173] (port=41096 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M92cW-0006cn-Lw for emacs-devel@gnu.org; Tue, 26 May 2009 15:47:33 -0400 Original-Received: from rcsinet12.oracle.com ([148.87.113.124]:58511 helo=rgminet12.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M92cW-0004OS-6E for emacs-devel@gnu.org; Tue, 26 May 2009 15:47:32 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4QJlIZS030806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 26 May 2009 19:47:20 GMT Original-Received: from abhmt002.oracle.com (abhmt002.oracle.com [141.146.116.11]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n4QJmFxl019368 for ; Tue, 26 May 2009 19:48:15 GMT Original-Received: from dradamslap1 (/141.144.90.50) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 May 2009 12:47:26 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <001d01c99543$ae7f1000$0200a8c0@us.oracle.com> Thread-Index: AcmVQ63ktLFiE9QAQ1embWXlfFG95BI9r/PQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt002.oracle.com [141.146.116.11] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090206.4A1C474F.00AA:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:111125 Archived-At: Any news on this patch? >---------8<------------ > From: Drew Adams Sent: Sunday, February 22, 2009 3:17 PM > The attached patches of `simple.el' and `compile.el' add and > respect a new value, `until-move', for options > `next-error-highlight' and `next-error-highlight-no-select'. > > The value of `t' is not adequate in a one-buffer-per-frame > environment (mine, at least). The problem is that the overlay > gets deleted upon the next command, and a switch-frame event > can act as the next command. Much of the time, the > highlighting is never seen, because a switch-frame event > (whether from the user or the code) causes it to disappear too quickly. > > Regardless of whether you are convinced that that is a problem, > I would argue that a user should be given the option of showing > the highlighting until the locus changes, regardless of the next command. > > The new value `until-move' does that: it moves the overlay > when you change locus, but it does not delete the overlay upon > the next command. IOW, it does not put > `compilation-goto-locus-delete-o' on `pre-command-hook'. > > (Personally, I'd prefer that `until-move' be the default > value, because I think it makes more sense for others too...) > > You may argue that if the value is `until-move', the overlay > is never deleted. Correct. So what? A user should still have > this option. > > In practice, it doesn't bother me at all that the overlay > remains, and I've been using this for years (long before > Emacs itself had such highlighting). > > If you really want a way for the user to get rid of the > overlay, then let `C-u C-u C-x `' do that, by adding this to > the beginning of the definition of `next-error': > > (if (and (consp arg) (= 16 (prefix-numeric-value arg)) > compilation-highlight-overlay) > (delete-overlay compilation-highlight-overlay) > ...)