unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Emacs-Devel devel'" <emacs-devel@gnu.org>
Subject: RE: patch for next-error highlighting
Date: Tue, 26 May 2009 12:47:50 -0700	[thread overview]
Message-ID: <DE64809A716A49D0881F0138471C2B65@us.oracle.com> (raw)
In-Reply-To: <001d01c99543$ae7f1000$0200a8c0@us.oracle.com>

Any news on this patch?

>---------8<------------
> From: Drew Adams Sent: Sunday, February 22, 2009 3:17 PM
> The attached patches of `simple.el' and `compile.el' add and 
> respect a new value, `until-move', for options
> `next-error-highlight' and `next-error-highlight-no-select'.
> 
> The value of `t' is not adequate in a one-buffer-per-frame 
> environment (mine, at least). The problem is that the overlay
> gets deleted upon the next command, and a switch-frame event
> can act as the next command. Much of the time, the
> highlighting is never seen, because a switch-frame event 
> (whether from the user or the code) causes it to disappear too quickly.
> 
> Regardless of whether you are convinced that that is a problem,
> I would argue that a user should be given the option of showing
> the highlighting until the locus changes, regardless of the next command.
> 
> The new value `until-move' does that: it moves the overlay 
> when you change locus, but it does not delete the overlay upon
> the next command. IOW, it does not put
> `compilation-goto-locus-delete-o' on `pre-command-hook'.
> 
> (Personally, I'd prefer that `until-move' be the default 
> value, because I think it makes more sense for others too...)
> 
> You may argue that if the value is `until-move', the overlay 
> is never deleted. Correct. So what? A user should still have
> this option.
> 
> In practice, it doesn't bother me at all that the overlay 
> remains, and I've been using this for years (long before
> Emacs itself had such highlighting). 
> 
> If you really want a way for the user to get rid of the 
> overlay, then let `C-u C-u C-x `' do that, by adding this to
> the beginning of the definition of `next-error':
> 
> (if (and (consp arg) (= 16 (prefix-numeric-value arg)) 
>          compilation-highlight-overlay)
>     (delete-overlay compilation-highlight-overlay)
>   ...)
 





      parent reply	other threads:[~2009-05-26 19:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-22 23:17 patch for next-error highlighting Drew Adams
2009-02-23  0:12 ` Miles Bader
2009-02-23  0:38   ` Drew Adams
2009-02-23  0:48     ` Miles Bader
2009-05-26 19:47 ` Drew Adams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DE64809A716A49D0881F0138471C2B65@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).