From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: master 63d69bd1549 07/11: Use new baseline indent rule in c-ts-mode Date: Mon, 2 Dec 2024 16:38:28 -0800 Message-ID: References: <173310542049.252624.8341603519407599366@vcs3.savannah.gnu.org> <20241202021023.2C8B8521785@vcs3.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17114"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 03 01:39:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIGx3-0004ER-67 for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Dec 2024 01:39:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIGwE-00077E-E0; Mon, 02 Dec 2024 19:38:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIGw9-00076z-JQ for emacs-devel@gnu.org; Mon, 02 Dec 2024 19:38:46 -0500 Original-Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIGw6-0000IU-Ji; Mon, 02 Dec 2024 19:38:44 -0500 Original-Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-7252f48acf2so3474498b3a.2; Mon, 02 Dec 2024 16:38:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733186320; x=1733791120; darn=gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XPlMn69No2aoUqlF7dEShIcWcydEqN7n7lBc3gF1Tkc=; b=O2ESUuPo5cqU4sf00v25++zDd+gUDOmoH+/sd1HxD4FndVwVEpUO1+7KGHzFU/aDqK 7y7oY6MtrITaQe2+/ftrTzNRb6TRpM7yg0WL0Ey2fBUR+vHff55ZyfdCLBOx1Eolt9ai oLHpwaZ6rjI9jDut+wMMdTndG8/CumMWB3i05Apag3hdUGzB9TPj97BoWPCBuzLGLqjY HHr6nrQ4+/QmtBGb2eT2HtQPQTpkpYdi0gYVQ35SXxIK4mNzM8F3KO8hRXGTB+FOep2G F43VucubBpv/08Mt2G4rTshQpu+WrlniIqjDRK+85myJabSZBdbSrSLPf3XbvhunCqVQ Uiqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733186320; x=1733791120; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XPlMn69No2aoUqlF7dEShIcWcydEqN7n7lBc3gF1Tkc=; b=Ejg2RdGyeFntmq2yh1FSGbdUjSwO5nuOHEKUwSsyA+ooPMkfUftJBo67Ty/IexDf6n Qg1q6lkEL4oXQG38XumZP6nUq3+uSE1QGlRdgGp9ScZ3O8xqgeqLoG3hxIQBcNEFGuud xVDIqbrU+61J5t5guUHdWQoq4VKX/sMaLPMwpXQlJfqxdAb9eNQ3YcULowS/AY3krAlm WnxPVvbGPT/EFlMVhrcwQCitBtrrM7fbdbdSD7LiybreCuDV01kAef7QiQ3HWztSN7zD vmceDMQ8jmfPNsmbgiLOSwQBGdRQXVfByeI64ZkNSQOOI/ovqddj1liD0wAcjPalhXkh B2vw== X-Gm-Message-State: AOJu0YywYYkW637LikmqZzuHUxlhnbHww99spBO63s0s5tkGs2CUDCay NwNUXe60l+6VzJtFu+7iROaWbODRR5vp/XPbORgotUIl8mGGxY4Ji19rNw== X-Gm-Gg: ASbGnctemRfjswD2Ft+NiZWt8HsGH1X39Q90YAhI+o4mdNCBpGCdVCcW/ZEVjz2NzJs E4o/sHfjZszH/iru9otUrz76+hro+UTD8NNr4eUTXVvWZMhRlh/IYaIeOcencBaBSUz/ElqLPZI cULqh2YcNFLxUs3UWfruoJO7nud5ErAgGAi9SRXde/ZPAw2BZ8wy8+iJj/MDPuECtLSPi7ykJdZ cuyQKXmpzNb/y2wPOXQjrlb+nHAVK0eZFrZdy1JT/UObSkRL1ax2IL4OoxfmXLCrn/+n8WhAQ== X-Google-Smtp-Source: AGHT+IFM67MMEHocVYjkdHJ/j4TjASlzWLKbjm+Maez5uVSRk157EgnhISZTQuux+vCrCLoRGxVIzw== X-Received: by 2002:a17:902:cecc:b0:215:b8b6:d2ea with SMTP id d9443c01a7336-215bceb300bmr8895235ad.15.1733186320027; Mon, 02 Dec 2024 16:38:40 -0800 (PST) Original-Received: from smtpclient.apple ([2601:646:8f81:6120:d4a2:bdb3:ccbc:4058]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2156c99a827sm42195575ad.166.2024.12.02.16.38.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Dec 2024 16:38:39 -0800 (PST) In-Reply-To: X-Mailer: Apple Mail (2.3776.700.51) Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=casouri@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:325959 Archived-At: > On Dec 2, 2024, at 1:02=E2=80=AFPM, Andrea Corallo = wrote: >=20 > Yuan Fu writes: >=20 >> branch: master >> commit 63d69bd154987bcc0434e0f85e09bf5dfa07b827 >> Author: Yuan Fu >> Commit: Yuan Fu >>=20 >> Use new baseline indent rule in c-ts-mode >>=20 >> Rework the indent rules in c-ts-mode using >> c-ts-common-baseline-indent-rule. Also reworked internal >> functions for setting indent styles to make it simpler and (more >> importantly) more readable. Now there's a single function, >> c-ts-mode--simple-indent-rules, that returns a value that can go >> straight to treesit-simple-indent-rules. >>=20 >> * lisp/progmodes/c-ts-mode.el: >> (c-ts-mode--indent-style-setter): Simplify. >> (c-ts-mode--get-indent-style): Remove function. >> (c-ts-mode--prompt-for-style): Use a hard-coded list of styles. >> This is a tiny downgrade from the computed lists but is >> acceptable. >> (c-ts-mode-set-style): Use c-ts-mode--simple-indent-rules. >> (c-ts-mode--standalone-grandparent): Docstring change. >> (c-ts-mode--for-loop-indent-rule): New function. >> (c-ts-mode--preproc-indent-rules): New variable. Copied from >> old indent rules and added some new rule. >> (c-ts-mode--macro-heuristic-rules): >> (c-ts-mode--simple-indent-rules): >> (c-ts-mode--parenthesized-expression-indent-rule): >> (c-ts-mode--label-indent-rules): New functions. >> (c-ts-mode): >> (c++-ts-mode): Use c-ts-mode--simple-indent-rules. >> --- >=20 > Hi Yuan, >=20 > this commit on my test-bench seems to introduce on master the = following > two failures: c-ts-mode-test-indentation-bsd, > c-ts-mode-test-indentation. >=20 > Could you have a look? >=20 > Andrea Hey Andrea, sorry about that. The tests do pass on my machine. How does = the test-bench run the tests? Yuan=